Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support transferable streams (postMessage) #1053

Merged
merged 30 commits into from
Aug 14, 2020
Merged

Support transferable streams (postMessage) #1053

merged 30 commits into from
Aug 14, 2020

Commits on Aug 13, 2020

  1. Support transferable streams (postMessage) 

    Make readable, writable, and transform streams transferable via
postMessage(stream, [stream]).

The streams themselves must be transferred, but the chunks written or
read from the streams are cloned, not transferred. Support for
transferring chunks will require API changes and is expected to be added
in a future update.

There is no reference implementation of this functionality as jsdom does
not support transferrable objects, and so it wouldn't be testable.

Closes whatwg#276.
    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    3620b28 View commit details
    Browse the repository at this point in the history

  2. Use American spelling for "uninitialized"

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    fdb3444 View commit details
    Browse the repository at this point in the history

  3. Add missing |error| argument. 

    Co-authored-by: Mattias Buelens <[email protected]>
    @ricea @MattiasBuelens
    ricea and MattiasBuelens committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    ecad896 View commit details
    Browse the repository at this point in the history

  4. Add missing "." 

    Co-authored-by: Domenic Denicola <[email protected]>
    @ricea @domenic
    ricea and domenic committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0444bdc View commit details
    Browse the repository at this point in the history

  5. Move the transfer steps into separate sections

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    00fa25c View commit details
    Browse the repository at this point in the history

  6. Update text for creating MessagePorts

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    86eed13 View commit details
    Browse the repository at this point in the history

  7. Move IsLocked checks earlier and throw a DataCloneError

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    780a016 View commit details
    Browse the repository at this point in the history

  8. Remove pointless Type settings for TransformStream

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    d239fd5 View commit details
    Browse the repository at this point in the history

  9. Initialise all slots in transferred TransformStream

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    6dfb817 View commit details
    Browse the repository at this point in the history

  10. Add missing "!"

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    353484a View commit details
    Browse the repository at this point in the history

  11. Clarify that it is Object.prototype we are worred about

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    225dcc4 View commit details
    Browse the repository at this point in the history

  12. Change paranoid checks to asserts, and add security warning

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    69c1a58 View commit details
    Browse the repository at this point in the history

  13. Remove optional "undefined" from call to PipeTo()

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0168dfd View commit details
    Browse the repository at this point in the history

  14. Use StructuredSerializeWithTransfer() to transfer MessagePort

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    5af0984 View commit details
    Browse the repository at this point in the history

  15. Explicitly enable port message queue

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    bbd6686 View commit details
    Browse the repository at this point in the history

  16. Add missing "."s

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    b09c403 View commit details
    Browse the repository at this point in the history

  17. Fix string quoting ("s" -> "s")

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    f6c032f View commit details
    Browse the repository at this point in the history

  18. Remove backpressurePromise from CrossRealmTransformReadable

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    7ee6687 View commit details
    Browse the repository at this point in the history

  19. Link {{ReadableStream}} 

    Co-authored-by: Domenic Denicola <[email protected]>
    @ricea @domenic
    ricea and domenic committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    7203f36 View commit details
    Browse the repository at this point in the history

  20. Put postMessage() in code font 

    Co-authored-by: Domenic Denicola <[email protected]>
    @ricea @domenic
    ricea and domenic committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    5c94076 View commit details
    Browse the repository at this point in the history

  21. Add missing formatting of port2 as var. 

    Co-authored-by: Domenic Denicola <[email protected]>
    @ricea @domenic
    ricea and domenic committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    86d347a View commit details
    Browse the repository at this point in the history

  22. Add Oxford comma 

    Co-authored-by: Domenic Denicola <[email protected]>
    @ricea @domenic
    ricea and domenic committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    dbb2fb4 View commit details
    Browse the repository at this point in the history

  23. Improve postMessage examples a bit

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    1370e5f View commit details
    Browse the repository at this point in the history

  24. Apply editorial tweaks to WritableStream and TransformStream sections

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    07df257 View commit details
    Browse the repository at this point in the history

  25. Use high-level operations in TransformStream transfer steps

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    cf47bfc View commit details
    Browse the repository at this point in the history

  26. Alphabetize the abstract ops

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    6a8b363 View commit details
    Browse the repository at this point in the history

  27. Make PackAndPostMessageHandlingError return a completion record

    @ricea
    ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    6e53603 View commit details
    Browse the repository at this point in the history

  28. Nits

    @domenic @ricea
    domenic authored and ricea committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    1a76913 View commit details
    Browse the repository at this point in the history

  29. Fix bad link text for "locked" 

    Co-authored-by: Mattias Buelens <[email protected]>
    @ricea @MattiasBuelens
    ricea and MattiasBuelens committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    017d200 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Linkify slots

    @ricea
    ricea committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    a5d56a9 View commit details
    Browse the repository at this point in the history