Skip to content

Commit

Permalink
Meta: upgrade webidl2js dependency in reference implementation
Browse files Browse the repository at this point in the history
As of version 17, webidl2js now creates iterators, exceptions and promises in the correct realm. This aligns the reference implementation closer to the standard.
  • Loading branch information
saschanaz authored Oct 18, 2023
1 parent 007d729 commit d58a68c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion reference-implementation/lib/ReadableStream-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports.implementation = class ReadableStreamImpl {
if (underlyingSource === undefined) {
underlyingSource = null;
}
const underlyingSourceDict = UnderlyingSource.convert(underlyingSource);
const underlyingSourceDict = UnderlyingSource.convert(globalObject, underlyingSource);

aos.InitializeReadableStream(this);

Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/lib/TransformStream-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports.implementation = class TransformStreamImpl {
if (transformer === undefined) {
transformer = null;
}
const transformerDict = Transformer.convert(transformer);
const transformerDict = Transformer.convert(globalObject, transformer);
if ('readableType' in transformerDict) {
throw new RangeError('Invalid readableType specified');
}
Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/lib/WritableStream-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports.implementation = class WritableStreamImpl {
if (underlyingSink === undefined) {
underlyingSink = null;
}
const underlyingSinkDict = UnderlyingSink.convert(underlyingSink);
const underlyingSinkDict = UnderlyingSink.convert(globalObject, underlyingSink);
if ('type' in underlyingSinkDict) {
throw new RangeError('Invalid type is specified');
}
Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"eslint": "^6.8.0",
"minimatch": "^3.0.4",
"opener": "^1.5.1",
"webidl2js": "^16.2.0",
"webidl2js": "^17.1.0",
"wpt-runner": "^5.0.0"
}
}

0 comments on commit d58a68c

Please sign in to comment.