Add advice for copyright notices on translations of Living Standards #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@triple-underscore since you produce the vast majority of the translations, it'd be good if you could take a look. Thanks! |
domenic
reviewed
Jan 10, 2018
triple-underscore
added a commit
to triple-underscore/triple-underscore.github.io
that referenced
this pull request
Jan 22, 2018
Adopting to: whatwg/sg#59 , whatwg/sg#40
|
I still need to address the review feedback on this. |
|
I'm not sure what's needed - would you please clarify? |
|
I'm just making a note for myself that I still need to address @domenic 's review comments, since it's been a few months. |
annevk
reviewed
Apr 29, 2019
kabat87
approved these changes
Jun 11, 2021
tantek
approved these changes
Jun 15, 2022
|
This generally looks good, but we no longer include YEAR and it would be good to double check it matches the current line. Though we don't want to include the new BSD source code bit. Translations shouldn't be incorporated into source code. |
Fixes #40 Since translations are generally produced independently, I framed this as a recommendation rather than a requirememt. Translators can technically do whatever they want as long as they follow the requirements of the license.
annevk
force-pushed
the
translation-notice
branch
from
37ce622 to
e1ea8f2
Compare
|
This should be good for final review now. |
foolip
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Since translations are generally produced independently, I framed this as a recommendation rather than a requirememt. Translators can technically do whatever they want as long as they follow the
requirements of the license.