Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange wording in warning #95

Closed
foolip opened this issue Mar 3, 2017 · 2 comments · Fixed by #98
Closed

Strange wording in warning #95

foolip opened this issue Mar 3, 2017 · 2 comments · Fixed by #98
Assignees
@beverloo

Comments

@foolip
Copy link
Member

foolip commented Mar 3, 2017

https://notifications.spec.whatwg.org/#dom-notification-requestpermission

In designing the platform notifications are the one instance thus far where asking the user upfront makes sense. Specifications for other APIs should not use this pattern and instead employ one of the many more suitable alternatives.

Right around the "are" I'm not sure how to continue parsing. Would suggest a fix but am not sure what was intended :)
@foolip
Copy link
Member Author

foolip commented Mar 3, 2017

Looks like this came from #36

beverloo added a commit to beverloo/notifications that referenced this issue Apr 11, 2017
@beverloo
Improve wording of the upfront-permission-request warning
1779473 
Fixes whatwg#95
@beverloo beverloo mentioned this issue Apr 11, 2017
Merged
@beverloo
Copy link
Member

Thanks! It predates the Bikeshed conversion, so probably has been there for a very long time. I've send a PR to improve the wording.

annevk pushed a commit that referenced this issue Apr 12, 2017
@beverloo @annevk
Editorial: improve the upfront-permission-request warning
fe20da2 
Fixes #95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beverloo beverloo

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve wording of the upfront-permission-request warning beverloo/notifications
2 participants
@beverloo @foolip