Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAssembly MIME type #95

Closed
wants to merge 1 commit into from
Closed

Conversation

littledan
Copy link

@littledan littledan commented Feb 28, 2019

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the additional newline back before the heading?

@domenic
Copy link
Member

domenic commented Mar 1, 2019

Do we think this is the right general practice going forward? I was kind of hoping that for non-complicated MIME types like wasm, people would just compare their essences inline. This doesn't feel like much of a group, compared to the existing ones which actually match more than one essence. (Except HTML MIME type, which I would support getting rid of.)

@annevk
Copy link
Member

annevk commented Mar 1, 2019

I kinda like the prose this creates, though it might make sense for the format specifications to host the definitions themselves. I don't feel strongly though.

@littledan
Copy link
Author

I have absolutely no opinion here; I was just about to link to the definition of "essence" from HTML, saw that I'd have to create a new link, and cargo-culted the other MIME types. @domenic 's suggestion sounds good to me.

I wanted to double-check: Should we be just matching against the essence application/wasm, or should we match exactly for that MIME type? I'm not sure if there's any other parameters that make sense to accept here.

@domenic
Copy link
Member

domenic commented Mar 1, 2019

That's a good question. It seems like the practice so far is to ignore unknown parameters instead of disallowing them, except for the legacy-ish special-case of the type="" attribute on scripts. I'm not sure if that was a principled decision, though.

@annevk
Copy link
Member

annevk commented Mar 1, 2019

Matching against the essence is what I recommend folks doing, mostly because this is what we do for every (wire) format, but also, it gives you two extension paths:

  1. Introduce backwards-compatible changes that still run in older clients via parameters.
  2. Introduce breaking changes via a new MIME type.

@littledan
Copy link
Author

I see, thanks for explaining. I'll follow up with this being just improved use of the essence definition directly from my PR against HTML.

@littledan littledan closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants