-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializing of MIME types without space before parameters might be problematic #84
Comments
So I think I'd prefer fixing this in XMLHttpRequest and here. Make XMLHttpRequest override less I'll prepare PRs. |
This will help web compatibility and address all cases linked from whatwg/mimesniff#84. Tests: ...
This is a defense-in-depth for the issues that arised at #84. In theory they are all solved by whatwg/xhr#224, but given how quickly several sites turned up that relied on a space, it seems prudent to standardize on that serialization to avoid similar issues elsewhere.
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1454325#c15 this also breaks an |
For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544.
This will help web compatibility and address all cases linked from whatwg/mimesniff#84. Tests: web-platform-tests/wpt#13779.
For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544.
Closing this as whatwg/xhr#224 got merged. No changes to MIME Sniffing needed after all. |
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
This will help web compatibility and address all cases linked from whatwg/mimesniff#84. Tests: web-platform-tests/wpt#13779.
It's a little bit unclear yet, but in the context of XMLHttpRequest where implementations currently modify in-place rather than parse-then-serialize for the
Content-Type
header during requests, Firefox noticed some issues switching strategies:This might end up affecting MIME type serialization slightly or end up being a change to XMLHttpRequest. I'm raising this here since I know other implementers are also looking at these algorithms and I'd like to keep everyone informed somehow.
cc @rwlbuis @MattMenke2
The text was updated successfully, but these errors were encountered: