Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEAM.md -> EDITORS.md? #64

Closed
annevk opened this issue Dec 19, 2017 · 6 comments
Closed

TEAM.md -> EDITORS.md? #64

annevk opened this issue Dec 19, 2017 · 6 comments

Comments

@annevk
Copy link
Member

annevk commented Dec 19, 2017

If we change this, and I think we should given the conflict with GitHub teams, it needs to be changed in whatwg/meta and whatwg/html. Anwhere else?

(We could also go for MAINTAINERS.md potentially, given that it's not always the editor that merges.)
@annevk annevk mentioned this issue Dec 19, 2017
Closed
@domfarolino
Copy link
Member

FWIW I like MAINTAINERS.md, for the reason you gave at the end there.

This was referenced Jan 4, 2018
Merged
Merged
Merged
@annevk annevk closed this as completed in #69 Jan 6, 2018
annevk pushed a commit that referenced this issue Jan 6, 2018
@snuggs @annevk
Meta: migrate TEAM.md -> MAINTAINERS.md
965a813 
Fixes #64.
annevk pushed a commit to whatwg/infra that referenced this issue Jan 6, 2018
@snuggs @annevk
Meta: update maintainers link
09a4b97 
Helps with whatwg/meta#64.

See also:
- whatwg/meta#69
- whatwg/meta#65
annevk pushed a commit to whatwg/html that referenced this issue Jan 6, 2018
@snuggs @annevk
Meta: migrate TEAM.md -> MAINTAINERS.md
6f22a50 
Helps with whatwg/meta#64

See also: whatwg/meta#69.
@annevk
Copy link
Member Author

annevk commented Jan 6, 2018

Thanks @snuggs for taking care of this!

@snuggs
Copy link
Member

snuggs commented Jan 6, 2018 •
edited
Loading

@annevk oh crap. Probably should have not used Fixes in this case. Perhaps Addresses.

My bust. A convention i've used in OSS for dependencies when you have a lot to maintain.

Can you re-open?

Dank je ;-)

https://help.github.com/articles/closing-issues-using-keywords/

@snuggs
Copy link
Member

snuggs commented Jan 6, 2018

oh ok as long as #65 is still open. Whew. ;-)

@annevk
Copy link
Member Author

annevk commented Jan 6, 2018

@snuggs yeah, I think it's fine that this one is closed. I fiddled a bit with your commit messages to make sure nothing else got closed. 😊

@snuggs
Copy link
Member

snuggs commented Jan 6, 2018 •
edited
Loading

@annevk #TeamWorkToMakeTheDreamWork 🎉

...or MAINTAINER work (pun intended).

alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@snuggs
Meta: migrate TEAM.md -> MAINTAINERS.md
94b3f74 
Helps with whatwg/meta#64

See also: whatwg/meta#69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snuggs @annevk @domfarolino