Define isomorphic string #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And define it alongside ASCII and scalar value strings.
annevk
force-pushed
the
annevk/isomorphic-string
branch
from
db2e629
to
4b9d443
Compare
|
I looked at this again and given that it gives us a type we don't even need the assert anymore. I've implemented this inline where applicable. I think that definitely makes this a valuable addition. |
domenic
approved these changes
Nov 14, 2024
|
ASCII string is already defined. This just moves the definition as is noted in the commit message. Unless I misunderstood? |
|
You're right, I just missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And define it alongside ASCII and scalar value strings.
I think this will be useful for Cookies, but I need to think about it some more. But also in general we should probably be able to assert around isomorphic decode/encode?
Preview | Diff