Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #955: Use robots.jpeg from html.spec instead of images.whatwg.org #961

Closed
wants to merge 1 commit into from
Closed

Fix #955: Use robots.jpeg from html.spec instead of images.whatwg.org #961

wants to merge 1 commit into from

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Mar 29, 2016

Hi guys,

Here is my attempt to close #955
Additionally I run this tool to make images smaller.
image-optim

Please let me know if this makes sense.
Thanks

@domenic
Copy link
Member

domenic commented Mar 29, 2016

Some of the colors seem to have been changed by imageOptim, at least as viewed in Firefox. So far I've seen content-venn and drawImage. GitHub's "swipe" diff viewer seems to be able to detect this.

@yuyokk
Copy link
Contributor Author

yuyokk commented Mar 29, 2016

Yes, seems you are right, some of the images slightly changed their colors.
I guess I will revert the second commit.

@yuyokk
Copy link
Contributor Author

yuyokk commented Mar 29, 2016

I've removed the second commit. Please check.

domenic
domenic reviewed Mar 29, 2016
View reviewed changes
source
@@ -36044,7 +36044,7 @@ The General Relativistic Field Equations</pre>
score. Suppose a robotics competition was being streamed live. The image could be overlayed with
the scores, as follows:</p>

<p><iframe src="data:text/html;charset=utf-8,%3C!DOCTYPE%20html%3E%0A%3Cstyle%3E%0A%20body%2C%20html%20%7B%20margin%3A%200%3B%20padding%3A%200%3B%20overflow%3A%20hidden%3B%20%7D%0A%20div%20%7B%20width%3A%20600px%3B%20height%3A%20400px%3B%20position%3A%20relative%3B%20%7D%0A%20p%20%7B%20position%3A%20absolute%3B%20top%3A%200%3B%20margin%3A%200.25em%3B%20font%3A%20small-caps%20900%202em%20sans-serif%3B%20text-shadow%3A%20white%200%200%204px%3B%20%7D%0A%20span%20%7B%20display%3A%20block%3B%20%7D%0A%20.left%20%7B%20color%3A%20red%3B%20left%3A%200%3B%20text-align%3A%20left%3B%20%7D%0A%20.right%20%7B%20color%3A%20blue%3B%20right%3A%200%3B%20text-align%3A%20right%3B%20%7D%0A%20.middle%20%7B%20color%3A%20white%3B%20top%3A%20auto%3B%20bottom%3A%200%3B%20left%3A%200%3B%20right%3A%200%3B%20text-align%3A%20center%3B%20text-shadow%3A%20black%200%200%204px%3B%20%7D%0A%20.middle%20span%20%7B%20display%3A%20inline-block%3B%20margin%3A%200%201em%3B%20font-size%3A%200.75em%3B%20text-transform%3A%20uppercase%3B%20%7D%0A%3C%2Fstyle%3E%0A%3Cdiv%3E%0A%20%3Cimg%20src%3D%22https%3A%2F%2Fimages.whatwg.org%2Frobots.jpeg%22%3E%0A%20%3Cp%20class%3D%22score%20left%22%3E%3Cspan%3ERed%20Alliance%3C%2Fspan%3E%20%3Cspan%3E78%3C%2Fspan%3E%3C%2Fp%3E%0A%20%3Cp%20class%3D%22score%20right%22%3E%3Cspan%3EBlue%20Alliance%3C%2Fspan%3E%20%3Cspan%3E66%3C%2Fspan%3E%3C%2Fp%3E%0A%20%3Cp%20class%3D%22score%20middle%22%3E%3Cspan%3EQual%20Match%2037%3C%2Fspan%3E%20%3Cspan%3EFriday%2014%3A21%3C%2Fspan%3E%0A%3C%2Fdiv%3E" width="600" height="400"></iframe>
<p><iframe src="data:text/html;charset=utf-8,%3C!DOCTYPE%20html%3E%0A%3Cstyle%3E%0A%20body%2C%20html%20%7B%20margin%3A%200%3B%20padding%3A%200%3B%20overflow%3A%20hidden%3B%20%7D%0A%20div%20%7B%20width%3A%20600px%3B%20height%3A%20400px%3B%20position%3A%20relative%3B%20%7D%0A%20p%20%7B%20position%3A%20absolute%3B%20top%3A%200%3B%20margin%3A%200.25em%3B%20font%3A%20small-caps%20900%202em%20sans-serif%3B%20text-shadow%3A%20white%200%200%204px%3B%20%7D%0A%20span%20%7B%20display%3A%20block%3B%20%7D%0A%20.left%20%7B%20color%3A%20red%3B%20left%3A%200%3B%20text-align%3A%20left%3B%20%7D%0A%20.right%20%7B%20color%3A%20blue%3B%20right%3A%200%3B%20text-align%3A%20right%3B%20%7D%0A%20.middle%20%7B%20color%3A%20white%3B%20top%3A%20auto%3B%20bottom%3A%200%3B%20left%3A%200%3B%20right%3A%200%3B%20text-align%3A%20center%3B%20text-shadow%3A%20black%200%200%204px%3B%20%7D%0A%20.middle%20span%20%7B%20display%3A%20inline-block%3B%20margin%3A%200%201em%3B%20font-size%3A%200.75em%3B%20text-transform%3A%20uppercase%3B%20%7D%0A%3C%2Fstyle%3E%0A%3Cdiv%3E%0A%20%3Cimg%20src%3D%22https%3A%2F%2Fhtml.spec.whatwg.org%2Fimages%2Frobots.jpeg%22%3E%0A%20%3Cp%20class%3D%22score%20left%22%3E%3Cspan%3ERed%20Alliance%3C%2Fspan%3E%20%3Cspan%3E78%3C%2Fspan%3E%3C%2Fp%3E%0A%20%3Cp%20class%3D%22score%20right%22%3E%3Cspan%3EBlue%20Alliance%3C%2Fspan%3E%20%3Cspan%3E66%3C%2Fspan%3E%3C%2Fp%3E%0A%20%3Cp%20class%3D%22score%20middle%22%3E%3Cspan%3EQual%20Match%2037%3C%2Fspan%3E%20%3Cspan%3EFriday%2014%3A21%3C%2Fspan%3E%0A%3C%2Fdiv%3E" width="600" height="400"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not have the explicit html.spec.... here, and just use /images/robots.jpeg instead like other places in the spec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what I'm doing wrong here but /images/robots.jpeg does not work for me locally
screenshot 2016-03-30 00 33 41
that's why I put html.spec. here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I see! Something about iframe data URLs, I guess... that's kind of annoying. Oh well!

domenic pushed a commit that referenced this pull request Mar 29, 2016
@yuyokk @domenic
Fix #955: Use robots.jpeg from html.spec instead of images.whatwg.org
50d7221 
We cannot use a relative URL like /images/robots.jpeg due to something
about iframe data: URLs as srcs.

PR: #961
@domenic
Copy link
Member

domenic commented Mar 29, 2016

Merged as 50d7221 with a quick note in the commit message about that weirdness. Thanks very much!

We should consider optimizing our images at some point, but it is a little worrying that imageOptim is lossy in strange ways.

@domenic domenic closed this Mar 29, 2016
@yuyokk yuyokk deleted the move-image branch March 29, 2016 22:51
@yuyokk
Copy link
Contributor Author

yuyokk commented Mar 29, 2016

I've been using imageOptim for a while and never paid attention on colors 😞
I will try to check other tools for image optimization sometime later.
Thank you for guidance!

@alrra
Copy link
Member

alrra commented Mar 29, 2016

Some of the colors seem to have been changed by imageOptim

@yuyokk, @domenic That happened because by default ImageOptim removes all color profiles.

@XhmikosR XhmikosR mentioned this pull request Jan 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move https://images.whatwg.org/robots.jpeg into this repository
3 participants
@yuyokk @domenic @alrra