Rename :open to :popover-open and remove :closed #9077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently under discussion here: w3c/csswg-drafts#8637
annevk
added
needs implementer interest
|
I guess we're largely waiting for a CSS WG resolution here? cc @whatwg/css @nt1m @jakearchibald |
|
That's my understanding, yeah. |
|
The CSSWG just resolved to make it |
josepharhar
changed the title
nt1m
approved these changes
Mar 30, 2023
|
Looks good to me. |
annevk
removed
the
needs implementer interest
|
@josepharhar can you complete the checklist in OP? You can consider WebKit to be interested. Thanks! |
Done |
annevk
approved these changes
Mar 31, 2023
There isn't an MDN page for popover yet though, is there? Is there an existing issue for popover or a draft of an MDN article...? |
|
(Small nit: can you rename the Chromium PR & WPT PR to use |
Mason is on it as we speak |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2023
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2023
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2023
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1124869}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2023
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1124869}
Done, and landed. 😄 |
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1124869}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 13, 2023
…lasses with ':popover-open'. r=emilio See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2023
…opovers, a=testonly Automatic update from web-platform-tests Convert `:open` to `:popover-open` for popovers See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1124869} -- wpt-commits: e68cb913b7cd3002609729bd2bde85b24ecaff39 wpt-pr: 39222
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 18, 2023
…lasses with ':popover-open'. r=emilio See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
luwes
added a commit
to luwes/selectlist-polyfill
that referenced
this pull request
Jun 17, 2023
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 17, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 17, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 18, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 18, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 18, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 20, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 20, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
mrobinson
pushed a commit
to servo/servo
that referenced
this pull request
Nov 21, 2023
…popover-open' See whatwg/html#9077. Differential Revision: https://phabricator.services.mozilla.com/D175223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently under discussion here: w3c/csswg-drafts#8637
:opento:popover-openfor popovers web-platform-tests/wpt#39222(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )
/semantics-other.html ( diff )