Add set up the request/validate the response hooks to script fetching #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
changed the title
domenic
force-pushed
the
module-service-workers
branch
from
6ae424e to
ea2b6d4
Compare
domenic
added
the
do not merge yet
annevk
force-pushed
the
module-service-workers
branch
from
ea2b6d4 to
b42dc2d
Compare
|
|
||
| <li><p>The caller specified custom steps to <span | ||
| data-x="fetching-scripts-validate-response">validate the response</span>, which when performed | ||
| on <var>response</var> return false.</p></li> |
There was a problem hiding this comment.
Steps are plural though...
domenic
removed
the
do not merge yet
|
I would like a LGTM from @jungkees as a comment here and then I'll merge. |
jungkees
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Feb 29, 2016
Define service worker's type to support both classic mode and module mode. Integrate fetch a classic worker script/fetch a module script tree in html with set up the request/validate the response hooks customized for service worker. Update Run Service Worker to run the script depending on the script's type. Changes in HTML: whatwg/html#746
|
LGTM. I also made a change in SW, accordingly: w3c/ServiceWorker@9111303 Please review it if I'm using it in the right way. |
This allows more complicated callers, like service workers, to customize script fetching as necessary. See [1], and in particular [2]. [1]: w3c/ServiceWorker#831 [2]: w3c/ServiceWorker#831 (comment)
annevk
force-pushed
the
module-service-workers
branch
from
b42dc2d to
33ef23a
Compare
jungkees
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Mar 2, 2016
Define service worker's type to support both classic mode and module mode. Integrate fetch a classic worker script/fetch a module script tree in html with set up the request/validate the response hooks customized for service worker. Update Run Service Worker to run the script depending on the script's type. Changes in HTML: whatwg/html#746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set up the request/validate the response hooks to script fetching
This allows more complicated callers, like service workers, to
customize script fetching as necessary. See 1, and in particular 2.
This is tagged "do not merge yet" since we should merge #745 first. I think they should be two separate commits to clarify the bugfixes vs. the new features.
Reviewers: @jungkees, @annevk, @mkruisselbrink.
The vision is that with these in hand the SW spec can do "fetch a classic worker script" or "fetch a module script tree", setting destination to "serviceworker" and with appropriate "set up the request" and "validate the response" steps.
Direct link to relevant changes in this PR (instead of the pieces from #745): 6ae424e