Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #655 - Allow createPattern to return null #677

Closed
wants to merge 1 commit into from
Closed

Fix #655 - Allow createPattern to return null #677

wants to merge 1 commit into from

Conversation

MichaelKohler
Copy link
Contributor

No description provided.

@MichaelKohler MichaelKohler force-pushed the issue655_createPattern_null_return branch from c48ef42 to 39e81e9 Compare February 11, 2016 00:04
@annevk
Copy link
Member

annevk commented Feb 11, 2016

Thank you! I noticed you are not yet in the acknowledgments section. Would you like to add yourself? If so, feel free to modify the existing commit and let me know when you have done so.

@MichaelKohler MichaelKohler force-pushed the issue655_createPattern_null_return branch from 39e81e9 to 1f45e25 Compare February 11, 2016 12:01
@MichaelKohler
Copy link
Contributor Author

Thanks Anne, done :)

annevk pushed a commit that referenced this pull request Feb 11, 2016
@MichaelKohler @annevk
Fix #655: createPattern() can return null
392c10a 
PR: #677
@annevk
Copy link
Member

annevk commented Feb 11, 2016

Thanks again. Committed as 392c10a.

@annevk annevk closed this Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelKohler @annevk