Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTMLMediaElement] Add a controlsList/controlslist attribute #6715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[HTMLMediaElement] Add a controlsList/controlslist attribute #6715

wants to merge 1 commit into from

Conversation

beaufortfrancois
Copy link

@beaufortfrancois beaufortfrancois commented May 25, 2021 •
edited by pr-preview bot
Loading

As discussed in #2426 (comment), this PR overseeds #2426 and adds a controlslist content attribute reflected by a DOMTokenList attribute named controlsList to the HTMLMediaElement for <audio> and <video> tags.

It specifies the following keywords: nodownload, nofullscreen, noplaybackrate (new in this PR) and noremoteplayback.

💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on May 25, 2021, 9:13 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

<html>
<head><title>524 Origin Time-out</title></head>
<body bgcolor="white">
<center><h1>524 Origin Time-out</h1></center>
<hr><center>cloudflare-nginx</center>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@beaufortfrancois
Copy link
Author

@domenic Please review

@beaufortfrancois beaufortfrancois mentioned this pull request May 25, 2021
Closed
@eric-carlson
Copy link

So it isn't lost with the new PR, WebKit's expressed opposition to this feature hasn't changed.

@domenic domenic added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest labels May 26, 2021
@beaufortfrancois
Copy link
Author

For reference, here's the related blink-dev thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/u9jsiarDEOg

@eric-carlson
Copy link

For reference, here's the related blink-dev thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/u9jsiarDEOg

Signals from other implementations (Gecko, WebKit):
Gecko: No Signal [1]
WebKit: No Signal [1]

Did you miss my comment about WebKit's opposition to this feature?

@beaufortfrancois
Copy link
Author

Argh! I did miss editing my blink-dev draft. Thanks for the ping @eric-carlson
I've updated the thread and the chrome status entry

@saeidasade321 saeidasade321 mentioned this pull request Jun 1, 2021
Closed
This was referenced Jun 3, 2021
Closed
Open
Merged
@tcitworld tcitworld mentioned this pull request Jun 25, 2021
Merged
@jpmedley
Copy link

Pinging this thread because my information says this is shipping in 93. Should this be in the spec for real?

@pngwn pngwn mentioned this pull request Jan 5, 2022
Merged
@jimmywarting
Copy link

How about being able to add custom buttons to the list? say like a quality picker for example.

@marcoscaceres marcoscaceres mentioned this pull request Feb 16, 2023
Open
@skyclouds2001 skyclouds2001 mentioned this pull request Jan 11, 2024
Merged
apepper added a commit to Scrivito/scrivito-portal-app that referenced this pull request Dec 2, 2024
@apepper
VideoWidget: Option to hide download button
b9a0223 
This option is currently only supported by chromium-based browsers (Chrome, Edge, Brave etc.). Firefox and Safari do _not_ support this option, since they both don't offer a download button at all (see whatwg/html#6715)
@apepper apepper mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beaufortfrancois @eric-carlson @jpmedley @jimmywarting @domenic