Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Change all 'Emit that' to 'Emit the current' #6610

Closed
wants to merge 2 commits into from

Conversation

Moosemorals
Copy link

@Moosemorals Moosemorals commented Apr 22, 2021

closes #6571


/parsing.html ( diff )

@annevk
Copy link
Member

annevk commented Apr 27, 2021

This looks reasonable and I appreciate you taking the time to do this, but I think we might have quite a bit of inconsistency left after this. E.g., we still have

Set the DOCTYPE token's force-quirks flag to on.

Emit the token.

Emit the comment token.

@zcorpan @domenic what do you think?

@annevk annevk added clarification Standard could be clearer topic: parser labels Apr 27, 2021
@zcorpan
Copy link
Member

zcorpan commented Apr 27, 2021

Yeah we could make all of them consistent, where it makes sense. In cases where a token is created and emitted in the same step, "the token" I think makes more sense. e.g. in the DOCTYPE state:

EOF
This is an eof-in-doctype parse error. Create a new DOCTYPE token. Set its force-quirks flag to on. Emit the token. Emit an end-of-file token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: parser
Development

Successfully merging this pull request may close these issues.

"Emit that DOCTYPE token"
3 participants