Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mutating <input disabled type=checkbox/radio> #5805

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Allow mutating <input disabled type=checkbox/radio> #5805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
723b799
Allow mutating <input disabled type=checkbox/radio>
saschanaz Aug 11, 2020
7465177
nits
saschanaz Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44689,8 +44689,9 @@ interface <dfn>HTMLInputElement</dfn> : <span>HTMLElement</span> {
agent should not allow the user to modify the element's <span
data-x="concept-fe-value">value</span> or <span data-x="concept-fe-checked">checkedness</span>.</p>

<p>When an <code>input</code> element is <span
data-x="concept-fe-disabled">disabled</span>, it is not <i
<p>When an <code>input</code> element is <span data-x="concept-fe-disabled">disabled</span> and
is not in the <span data-x="attr-input-type-checkbox">Checkbox</span> nor <span
data-x="attr-input-type-radio">Radio</span> states, it is not <i
data-x="concept-fe-mutable">mutable</i>.</p>
domenic marked this conversation as resolved.
Show resolved Hide resolved

<p class="note">The <code data-x="attr-input-readonly">readonly</code> attribute can also in some
Expand All @@ -44708,7 +44709,9 @@ interface <dfn>HTMLInputElement</dfn> : <span>HTMLElement</span> {
<p>The <span>activation behavior</span> for <code>input</code> elements are these steps:</p>

<ol>
<li><p>If this element is not <i data-x="concept-fe-mutable">mutable</i>, then return.</p></li>
<li><p>If this element is not <i data-x="concept-fe-mutable">mutable</i> and is not in <span
data-x="attr-input-type-checkbox">Checkbox</span> nor <span data-x="attr-input-type-radio">
Radio</span>, then return.</p></li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a late second look, and this specific change now looks redundant as they are now always mutable per the first change anyway. What do you think? @domenic

Copy link
Member Author

@saschanaz saschanaz Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we can keep this and revert the first change because disabled checkboxes are not user-mutable. (And AFAICT "mutable" is defined as being mutable via user interface)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point, yes, we should keep this and revert the first change. Thank you for double-checking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, although mutability also impacts legacy-pre-activation behavior and legacy-canceled-activation behavior. So maybe we need to add checks there too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those behaviors only apply for radio/checkboxes so maybe the mutability check can be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great point, yes, I think they can be removed.


<li><p>Run this element's <dfn>input activation behavior</dfn>, if any, and do nothing
otherwise.</p></li>
Expand Down