-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consult .name instead of [[Prototype]] for Error serialization #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
annevk
reviewed
Jan 2, 2020
I think it's okay to assume Mozilla is okay with this. |
annevk
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though Mozilla would most likely prefer accepting that errors have an internal slot, as they do in all implementations.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2020
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jan 9, 2020
…erialization, a=testonly Automatic update from web-platform-tests Add/update tests for cross-realm Error serialization Follows whatwg/html#5150. -- wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846 wpt-pr: 20771
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 9, 2020
…erialization, a=testonly Automatic update from web-platform-tests Add/update tests for cross-realm Error serialization Follows whatwg/html#5150. -- wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846 wpt-pr: 20771
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 11, 2020
…erialization, a=testonly Automatic update from web-platform-tests Add/update tests for cross-realm Error serialization Follows whatwg/html#5150. -- wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846 wpt-pr: 20771 UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 11, 2020
…erialization, a=testonly Automatic update from web-platform-tests Add/update tests for cross-realm Error serialization Follows whatwg/html#5150. -- wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846 wpt-pr: 20771 UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 11, 2020
…erialization, a=testonly Automatic update from web-platform-tests Add/update tests for cross-realm Error serialization Follows whatwg/html#5150. -- wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846 wpt-pr: 20771 UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
johanholmerin
added a commit
to johanholmerin/structured-clone
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5140.
(See WHATWG Working Mode: Changes for more details.)
/structured-data.html ( diff )