Adjust rules for parsing dimension values #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky
approved these changes
Jul 1, 2019
|
I can add wpts in https://bugzilla.mozilla.org/show_bug.cgi?id=1562690 |
|
@annevk As I said in #4726 (comment) it looks like I had mis-tested Chrome somehow and they do not allow ".5". So maybe we should keep not allowing it, since Safari is the only browser that parses that. |
|
Thanks for noticing that. I dropped that bit from the PR, the eventual commit message should drop the "Allow a leading dot" line. |
|
I filed https://bugs.webkit.org/show_bug.cgi?id=199398 against Safari for the leading dot bug. |
|
Thanks, the updated spec text looks great! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 3, 2019
…te and align better with other browsers. r=mccr8 See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 --HG-- extra : moz-landing-system : lando
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 11, 2019
…better with other browsers. See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562690 gecko-commit: 0db6b1468cc36416a86f9a8a70da14f878281929 gecko-integration-branch: central gecko-reviewers: mccr8
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 11, 2019
…better with other browsers. See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562690 gecko-commit: 0db6b1468cc36416a86f9a8a70da14f878281929 gecko-integration-branch: central gecko-reviewers: mccr8
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…better with other browsers. See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562690 gecko-commit: 0db6b1468cc36416a86f9a8a70da14f878281929 gecko-integration-branch: central gecko-reviewers: mccr8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…te and align better with other browsers. r=mccr8 See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 UltraBlame original commit: 0db6b1468cc36416a86f9a8a70da14f878281929
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…te and align better with other browsers. r=mccr8 See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 UltraBlame original commit: 0db6b1468cc36416a86f9a8a70da14f878281929
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…te and align better with other browsers. r=mccr8 See whatwg/html#4747 for the spec changes Differential Revision: https://phabricator.services.mozilla.com/D36643 UltraBlame original commit: 0db6b1468cc36416a86f9a8a70da14f878281929
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
(See WHATWG Working Mode: Changes for more details.)
/common-microsyntaxes.html ( diff )