Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Policy: focus-without-user-activation #4585

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature Policy: focus-without-user-activation #4585

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e312f2
Spec change for focus without activation
ehsan-karamad Apr 30, 2019
a4d70ee
Use the right verbiage for policy
ehsan-karamad May 9, 2019
80db01d
use 'allow to use the ... feature' pattern
ehsan-karamad May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4395,6 +4395,9 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li>"<dfn data-x="document-domain-feature"><code data-x="">document-domain</code></dfn>", which
has a <span data-x="concept-default-allowlist">default allowlist</span> of <code
data-x="">*</code>.</li>
<li>"<dfn data-x="focus-without-user-activation-feature"><code
data-x="">focus-without-user-activation</code></dfn>", which has a <span
data-x="concept-default-allowlist">default allowlist</span> of <code data-x="">*</code>.</li>
</ul>


Expand Down Expand Up @@ -53257,6 +53260,11 @@ form.method === input; // => true</code></pre>
<li><p>If <var>target</var>'s <span>active sandboxing flag set</span> has the
<span>sandboxed automatic features browsing context flag</span>, then return.</p></li>

<li><p>If this algorithm is not <span>triggered by user activation</span> and the
<var>target</var> is not <span>allowed to use</span> the "<code
data-x="focus-without-user-activation-feature">focus-without-user-activation</code>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the correct verbiage here is

<var>target</var> is not <span>allowed to use</span> the "<code
data-x="focus-without-user-activation-feature">focus-without-user-activation</code>" feature

Cf. https://html.spec.whatwg.org/#playing-the-media-resource:allowed-to-use

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Done.

then return.</p></li>

<li><p>If <var>target</var>'s <span>origin</span> is not the <span data-x="same
origin">same</span> as the <span>origin</span> of the <span>node document</span> of the currently
focused element in <var>target</var>'s <span>top-level browsing context</span>, then
Expand Down Expand Up @@ -73752,6 +73760,11 @@ END:VCARD</pre>

<li><p>If <var>current</var> is null, then return.</p></li>

<li><p>If this algorithm is not <span>triggered by user activation</span> and
<var>current</var>'s <span>active document</span> is not <span>allowed to use</span> "<code
data-x="focus-without-user-activation-feature">focus-without-user-activation</code>", then
return.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional nit: we're slowly moving toward using "then" for new if statements, so "then return". (Like the previous bullet.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


<li><p>Run the <span>focusing steps</span> with <var>current</var>.</p></li>

<li><p>If <var>current</var> is a <span>top-level browsing context</span>, user agents are
Expand All @@ -73778,6 +73791,11 @@ END:VCARD</pre>

<ol>

<li><p>If this algorithm is not <span>triggered by user activation</span> and the element's
<span>node document</span> is not <span>allowed to use</span> "<code
data-x="focus-without-user-activation-feature">focus-without-user-activation</code>", then
return.</p></li>

<li><p>If the element is marked as <i data-x="locked for focus">locked for focus</i>, then return.</p></li>

<li><p>Mark the element as <dfn>locked for focus</dfn>.</p></li>
Expand Down Expand Up @@ -122555,6 +122573,7 @@ INSERT INTERFACES HERE
Edward Welbourne,
Edward Z. Yang,
Ehsan Akhgari,
Ehsan Karamad,
Eira Monstad,
Eitan Adler,
Eli Friedman,
Expand Down