-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete=one-time-code
. Fixes whatwg/html#3745
#4573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will leave un-merged for a day or two in case anyone else wants to take a look.
<td>One-time code used for verifying user identity | ||
<td>Free-form text, no newlines | ||
<td>123456 | ||
<td><span data-x="Control Group Password">Password</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For any other reviewers, it turns out this includes input type=text as well: http://localhost:8080/#control-group-password
heads-up @whatwg/documentation |
Added to MDN: Added to HTML checker: |
In what browser has this been implemented?
Joe Medley | Technical Writer, Chrome DevRel | [email protected] |
816-678-7195
*If an API's not documented it doesn't exist.*
…On Sun, Apr 28, 2019 at 4:37 PM Michael[tm] Smith ***@***.***> wrote:
Added to MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete$compare?to=1546633&from=1480916
Added to HTML checker:
***@***.***
<validator/validator@c7b7f85>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#4573 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB6S7C3RESSAV3MDCX2P2RDPSYYNDANCNFSM4HI2DPQQ>
.
|
@jpmedley I'm guessing #3745 (comment) is right and nobody else has implemented this yet. Nobody passes the test at this time, though. The test has been merged; @domenic can you merge this, or are we waiting for something? |
whatwg/html#4573, a=testonly Automatic update from web-platform-tests HTML: test autocomplete=one-time-code (#16565) For whatwg/html#4573 -- wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b wpt-pr: 16565
whatwg/html#4573, a=testonly Automatic update from web-platform-tests HTML: test autocomplete=one-time-code (#16565) For whatwg/html#4573 -- wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b wpt-pr: 16565
whatwg/html#4573, a=testonly Automatic update from web-platform-tests HTML: test autocomplete=one-time-code (#16565) For whatwg/html#4573 -- wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b wpt-pr: 16565 UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
whatwg/html#4573, a=testonly Automatic update from web-platform-tests HTML: test autocomplete=one-time-code (#16565) For whatwg/html#4573 -- wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b wpt-pr: 16565 UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
whatwg/html#4573, a=testonly Automatic update from web-platform-tests HTML: test autocomplete=one-time-code (#16565) For whatwg/html#4573 -- wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b wpt-pr: 16565 UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
This autocomplete value can be used by some browsers to automatically fill in the value after receiving a one-time-code for 2-factor authentication. More info: - whatwg/html#4573 - https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element - https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#Values - https://www.twilio.com/blog/html-attributes-two-factor-authentication-autocomplete
This autocomplete value can be used by some browsers to automatically fill in the value after receiving a one-time-code for 2-factor authentication. More info: - whatwg/html#4573 - https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element - https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#Values - https://www.twilio.com/blog/html-attributes-two-factor-authentication-autocomplete
See the corresponding issue and web-platform-tests PR.
/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )