Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Window's close(d) members #4402

Merged
merged 7 commits into from
Mar 7, 2019
Merged

Cleanup Window's close(d) members #4402

merged 7 commits into from
Mar 7, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 1, 2019 •
edited by pr-preview bot
Loading

domenic
domenic approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially LGTM; were there questions about the correct behavior for these ones?

@annevk
Copy link
Member Author

annevk commented Mar 1, 2019

Yeah, see #3734 and pointers from there. I didn't do anything to try address those.

@domenic
Copy link
Member

domenic commented Mar 1, 2019

Wrong issue link?

But I meant, it seems like the ones in this patch are uncontroversial. Right?

@annevk
Copy link
Member Author

annevk commented Mar 1, 2019

No, that issue is relevant for close(). I don't think any of changes are controversial, indeed.

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Mar 1, 2019
@annevk annevk mentioned this pull request Mar 1, 2019
Closed
annevk
annevk commented Mar 4, 2019
View reviewed changes
source Show resolved Hide resolved
@annevk annevk mentioned this pull request Mar 4, 2019
Open
@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Mar 4, 2019
domenic
domenic reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task source/event loop is the main remaining thing. It seems not too hard to do so I'd say might as well do it now?

Also will want a new commit message.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
domenic
domenic approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but examples would be a nice bonus.

@annevk annevk mentioned this pull request Mar 7, 2019
Closed
annevk added a commit to web-platform-tests/wpt that referenced this pull request Mar 7, 2019
@annevk
HTML: window.closed
391ee6b 
For whatwg/html#4402.
@annevk annevk merged commit 37b1ce5 into master Mar 7, 2019
@annevk annevk deleted the annevk/window-close(d) branch March 7, 2019 15:47
@annevk
Copy link
Member Author

annevk commented Mar 7, 2019 •
edited
Loading

Filed https://bugs.webkit.org/show_bug.cgi?id=195409 on Safari and #4417 for examples.

@annevk annevk mentioned this pull request Mar 7, 2019
Merged
annevk added a commit to web-platform-tests/wpt that referenced this pull request Mar 8, 2019
@annevk
HTML: test queueing behavior of window.close()
bdb6041 
For whatwg/html#4402.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 1, 2019
@annevk @jgraham
Bug 1531625 [wpt PR 15561] - HTML: window.closed, a=testonly
73464e0 
Automatic update from web-platform-tests
HTML: window.closed

For whatwg/html#4402.
--

wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c
wpt-pr: 15561
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 1, 2019
@annevk @jgraham
Bug 1534493 [wpt PR 15649] - HTML: test queueing behavior of window.c…
79fdfac 
…lose(), a=testonly

Automatic update from web-platform-tests
HTML: test queueing behavior of window.close()

For whatwg/html#4402.
--

wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3
wpt-pr: 15649
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 2, 2019
@annevk @jgraham
Bug 1531625 [wpt PR 15561] - HTML: window.closed, a=testonly
0a727ca 
Automatic update from web-platform-tests
HTML: window.closed

For whatwg/html#4402.
--

wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c
wpt-pr: 15561
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 2, 2019
@annevk @jgraham
Bug 1534493 [wpt PR 15649] - HTML: test queueing behavior of window.c…
e90a0db 
…lose(), a=testonly

Automatic update from web-platform-tests
HTML: test queueing behavior of window.close()

For whatwg/html#4402.
--

wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3
wpt-pr: 15649
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
@annevk
HTML: window.closed
2cf2eec 
For whatwg/html#4402.
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
@annevk
HTML: test queueing behavior of window.close()
a656459 
For whatwg/html#4402.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1531625 [wpt PR 15561] - HTML: window.closed, a=testonly
ce843dd 
Automatic update from web-platform-tests
HTML: window.closed

For whatwg/html#4402.
--

wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c
wpt-pr: 15561

UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1534493 [wpt PR 15649] - HTML: test queueing behavior of window.c…
071c593 
…lose(), a=testonly

Automatic update from web-platform-tests
HTML: test queueing behavior of window.close()

For whatwg/html#4402.
--

wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3
wpt-pr: 15649

UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1531625 [wpt PR 15561] - HTML: window.closed, a=testonly
dc0a527 
Automatic update from web-platform-tests
HTML: window.closed

For whatwg/html#4402.
--

wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c
wpt-pr: 15561

UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1534493 [wpt PR 15649] - HTML: test queueing behavior of window.c…
d5c64a4 
…lose(), a=testonly

Automatic update from web-platform-tests
HTML: test queueing behavior of window.close()

For whatwg/html#4402.
--

wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3
wpt-pr: 15649

UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1531625 [wpt PR 15561] - HTML: window.closed, a=testonly
7c4fd1f 
Automatic update from web-platform-tests
HTML: window.closed

For whatwg/html#4402.
--

wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c
wpt-pr: 15561

UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1534493 [wpt PR 15649] - HTML: test queueing behavior of window.c…
5bae706 
…lose(), a=testonly

Automatic update from web-platform-tests
HTML: test queueing behavior of window.close()

For whatwg/html#4402.
--

wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3
wpt-pr: 15649

UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb
@hober hober mentioned this pull request Dec 10, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: browsing context
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic