Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support <form rel> #4332

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Support <form rel> #4332

merged 2 commits into from
Feb 14, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 1, 2019 •
edited by pr-preview bot
Loading

In particular to enable noopener, noreferrer, and opener values.

Also default target=_blank to noopener.

Tests: ...

Fixes #2983.

/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )
/forms.html ( diff )
/links.html ( diff )

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Feb 1, 2019
@annevk
Support <form rel>
af22fbd 
In particular to enable noopener, noreferrer, and opener values.

Also default target=_blank to noopener.

Tests: ...

Fixes #2983.
@annevk annevk force-pushed the annevk/form-rel-and-_blank branch from e24ca70 to af22fbd Compare February 7, 2019 12:33
@annevk annevk added topic: forms and removed do not merge yet Pull request must not be merged per rationale in comment labels Feb 7, 2019
@annevk annevk mentioned this pull request Feb 7, 2019
Closed
@annevk
Copy link
Member Author

annevk commented Feb 7, 2019

Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1509346.

@ehsan
Copy link

ehsan commented Feb 7, 2019

WebKit: https://bugs.webkit.org/show_bug.cgi?id=194398

domenic
domenic approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. Nicely done threading this through everything.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source
@@ -56078,9 +56139,12 @@ fur
be the result of <span data-x="get an element's target">getting an element's target</span> given
<var>submitter</var>'s <span>form owner</span>.</p></li>

<li><p>Let <var>noopener</var> be the result of <span data-x="get an element's noopener">getting
an element's noopener</span> with <var>form</var> and <var>targetAttributeValue</var>.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formtarget="" interaction is subtle and will need tests. Nice catch including it here. (I forgot that attribute existed.)

sideshowbarker
sideshowbarker reviewed Feb 11, 2019
View reviewed changes
source Outdated Show resolved Hide resolved
@annevk
Copy link
Member Author

annevk commented Feb 11, 2019

Reached out to microformats at https://freenode.logbot.info/microformats/20190211#c1987546.

@kevinmarks kevinmarks mentioned this pull request Feb 11, 2019
Open
@annevk
Copy link
Member Author

annevk commented Feb 12, 2019

I'm assuming everything here is in order now, except for tests, but another quick skim through the proposed text might be good.

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=931209 on Chromium, which concludes filing bugs for this feature.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Feb 12, 2019
@annevk
HTML: <form rel> WIP
f7dbb8a 
For whatwg/html#4332.
@annevk annevk mentioned this pull request Feb 12, 2019
Merged
@annevk annevk merged commit cf483d3 into master Feb 14, 2019
@annevk annevk deleted the annevk/form-rel-and-_blank branch February 14, 2019 13:25
@annevk annevk added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Feb 14, 2019
@annevk
Copy link
Member Author

annevk commented Feb 14, 2019

cc @whatwg/documentation

foolip pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 15, 2019
@annevk @foolip
HTML: <form rel> (#15356)
b44dacf 
For whatwg/html#4332.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 15, 2019
@annevk @jgraham
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
85260ef 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Mar 16, 2019
@annevk @jgraham
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
00725d8 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 16, 2019
@annevk @jgraham
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
16c1167 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Mar 17, 2019
@annevk @jgraham
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
84d2dbe 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
@annevk
HTML: <form rel> (#15356)
099ed57 
For whatwg/html#4332.
This was referenced Aug 8, 2019
Open
Open
Closed
@Malvoz Malvoz mentioned this pull request Aug 11, 2019
Open
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
a4e1133 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 16b6e709d409e86ea85e951e25ac4752fd4c9aba
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
11f89e5 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 8324cb961aaf665330e8e1a13d95836c5edd5ffa
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
d8fa23d 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 16b6e709d409e86ea85e951e25ac4752fd4c9aba
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
9bc538b 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 8324cb961aaf665330e8e1a13d95836c5edd5ffa
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
4251224 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 16b6e709d409e86ea85e951e25ac4752fd4c9aba
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1527661 [wpt PR 15356] - HTML: <form rel>, a=testonly
3fb2763 
Automatic update from web-platform-tests
HTML: <form rel> (#15356)

For whatwg/html#4332.

--

wpt-commits: b44dacf7a939fd93f3afb0c46f8f89d71ea20409
wpt-pr: 15356

UltraBlame original commit: 8324cb961aaf665330e8e1a13d95836c5edd5ffa
@hober hober mentioned this pull request Dec 10, 2019
Closed
4 tasks
curbengh pushed a commit to curbengh/curbengh.github.io that referenced this pull request Apr 15, 2020
fix(search): do not send referrer
78397da 
- https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types
- whatwg/html#2983
- whatwg/html#4332
@kiding kiding mentioned this pull request Feb 15, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation topic: forms
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @ehsan @sideshowbarker @domenic