Specify which settings object is used for dynamic import #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the HostImportModuleDynamically algorithm use referencing script's settings object, that is, an environment settings object. Before this patch, the algorithm uses an unspecified settings object.
nyaxt
suggested changes
May 22, 2018
|
@nyaxt Done |
nyaxt
approved these changes
May 22, 2018
|
@nyaxt My previous comment meant "Participant Agreement". I also added my name to the contributors in Acknowledgements :) |
domenic
requested changes
May 22, 2018
source
Outdated
| <li><p><span>Fetch a module script graph</span> given <var>url</var>, <var>referencing | ||
| script</var>'s <span>settings object</span>, "<code data-x="">script</code>", and | ||
| <var>options</var>. Wait until the algorithm asynchronously completes with <var>result</var>. | ||
| </p></li> |
There was a problem hiding this comment.
Nit: this linebreak adds an extra space after the period. Instead, please linebreak before the <var>
domenic
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the HostImportModuleDynamically algorithm use
referencing script's settings object, that is, an environment
settings object.
Before this patch, the algorithm uses an unspecified settings object.
cc: @nyaxt
/acknowledgements.html ( diff )
/webappapis.html ( diff )