Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history.index #2944

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Add history.index #2944

merged 1 commit into from
Aug 23, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 18, 2017

Closes #2710.

@domenic domenic added addition/proposal New features or enhancements topic: history labels Aug 18, 2017
@domenic domenic mentioned this pull request Aug 18, 2017
Closed
@zcorpan zcorpan added the needs tests Moving the issue forward requires someone to write tests label Aug 21, 2017
@domenic
Copy link
Member Author

domenic commented Aug 23, 2017

Tests at https://chromium-review.googlesource.com/c/596716

@domenic domenic removed the needs tests Moving the issue forward requires someone to write tests label Aug 23, 2017
@domenic domenic merged commit f8e293f into master Aug 23, 2017
@domenic domenic deleted the history-index branch August 23, 2017 04:41
@domenic
Copy link
Member Author

domenic commented Aug 23, 2017

Bugs filed:

@domenic
Copy link
Member Author

domenic commented Feb 7, 2018

I've posted #3460 to revert this and remove history.index from the spec for now.

@domenic domenic mentioned this pull request Feb 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
addition/proposal New features or enhancements topic: history
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenic @zcorpan @dvoytenko