-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of how module maps are keyed #2193
Conversation
This transposes some of the wisdom from #443 (comment) into the spec.
|
||
<pre>import "https://example.com/module.js"; | ||
import "https://example.com/module.js#map-buster"; | ||
import "https://example.com/%6dodule.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think currently in Chrome this will be normalized. I currently think the URL Standard will end up not normalizing it, but who knows what the future brings so might be best to leave this example out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm OK. Are there other examples of things that most servers interpret as equivalent but don't involve fragments (or queries)? I thought that was a nice point made in #443 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only one for paths I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hosts works fine too :). But I guess I can find many examples of host canonicalization on my own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hosts normalize during parsing. Before we normalized IP addresses during parsing there was that ability, but no longer.
Thanks! This clarification is very helpful. |
@annevk mind reviewing this again? |
This transposes some of the wisdom from
#443 (comment) into the
spec.
/cc @dominiccooney @nyaxt