Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of how module maps are keyed #2193

Merged
merged 2 commits into from
Jan 11, 2017
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Dec 19, 2016

This transposes some of the wisdom from
#443 (comment) into the
spec.

/cc @dominiccooney @nyaxt

This transposes some of the wisdom from
#443 (comment) into the
spec.

<pre>import "https://example.com/module.js";
import "https://example.com/module.js#map-buster";
import "https://example.com/%6dodule.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think currently in Chrome this will be normalized. I currently think the URL Standard will end up not normalizing it, but who knows what the future brings so might be best to leave this example out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm OK. Are there other examples of things that most servers interpret as equivalent but don't involve fragments (or queries)? I thought that was a nice point made in #443 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one for paths I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hosts works fine too :). But I guess I can find many examples of host canonicalization on my own.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hosts normalize during parsing. Before we normalized IP addresses during parsing there was that ability, but no longer.

@nyaxt
Copy link
Member

nyaxt commented Dec 20, 2016

Thanks! This clarification is very helpful.

@domenic
Copy link
Member Author

domenic commented Jan 10, 2017

@annevk mind reviewing this again?

@domenic domenic added the clarification Standard could be clearer label Jan 11, 2017
@domenic domenic merged commit c922eda into master Jan 11, 2017
@domenic domenic deleted the clarify-module-map-keys branch January 11, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

Successfully merging this pull request may close these issues.

3 participants