Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend environment concept #2004

Merged
merged 6 commits into from
Nov 9, 2016
Merged

Extend environment concept #2004

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a1ef04
Extend environment concept
jungkees Nov 2, 2016
69f75c3
Add data-x to origin to resolve multiple definition error
jungkees Nov 2, 2016
e1ced39
Add data-dfn-for attribute to execution ready flag
jungkees Nov 2, 2016
ed8576e
Remove the origin algorithm
jungkees Nov 4, 2016
655c603
Move execution ready flag into <dl>
jungkees Nov 7, 2016
de7dde4
Use let for variable introduction
jungkees Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76515,8 +76515,8 @@ dictionary <dfn>DragEventInit</dfn> : <span>MouseEventInit</span> {
</ul>
</li>

<li><p><span>Set up a browsing context environment settings object</span> with
<var>realm execution context</var>.</p></li>
<li><p><span>Set up a browsing context environment settings object</span> with <var>realm
execution context</var>, and let <var>settingsObject</var> be the result.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let settingsObject be the result; this is the first introduction of the settingsObject variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the comment. Thanks.


<li><p>Let <var>document</var> be a new <code>Document</code>, marked as an <span data-x="HTML
documents">HTML document</span> in <span>quirks mode</span>, whose <span
Expand Down Expand Up @@ -76560,6 +76560,9 @@ dictionary <dfn>DragEventInit</dfn> : <span>MouseEventInit</span> {

<li><p><span>Implement the sandboxing</span> for <var>document</var>.</p></li>

<li><p>Set <var>settingsObject</var>'s <span
data-x="concept-environment-execution-ready-flag">execution ready flag</span>.</p></li>

<li><p>Add <var>document</var> to <var>browsingContext</var>'s <span>session
history</span>.</p></li>

Expand Down Expand Up @@ -81795,6 +81798,9 @@ State: &lt;OUTPUT NAME=I>1&lt;/OUTPUT> &lt;INPUT VALUE="Increment" TYPE=BUTTON O

<li><p><span>Implement the sandboxing</span> for the <code>Document</code>.</p></li>

<li><p>Set <var>settingsObject</var>'s <span
data-x="concept-environment-execution-ready-flag">execution ready flag</span>.</p></li>

<li>
<p>If <var>settingsObject</var>'s <span
data-x="concept-environment-active-service-worker">active service worker</span> is not null,
Expand Down Expand Up @@ -85798,6 +85804,11 @@ interface <dfn>NavigatorOnLine</dfn> {
data-dfn-for="environment">active service worker</dfn></dt>
<dd><p>Null or a <span data-x="dfn-service-worker">service worker</span> that <span
data-x="dfn-control">controls</span> the <span>environment</span>.</p></dd>

<dt>An <dfn data-x="concept-environment-execution-ready-flag" data-export=""
data-dfn-for="environment">execution ready flag</dfn></dt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to the previous <dl>, I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether I should get both the fields and the flag in the same <dl> considering we put it as "An environment has the following fields". So, I guess a flag is a field? I'm fine with adding it to the <dl> if so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A field can be a flag, yeah :). Flag is a type, kind of like a boolean but just a bit more awkward to use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Addressed the comment.

<dd><p>A flag that indicates whether the environment setup is done. It is initially
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also have a data-dfn-for="environment".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. just missed this comment before pushing the data-x commit. Will add this.

unset.</p></dd>
</dl>

<p>An <dfn data-export="">environment settings object</dfn> is an <span>environment</span> that
Expand Down Expand Up @@ -96360,6 +96371,9 @@ interface <dfn>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope</span> {

</li>

<li><p>Set <var>inside settings</var>'s <span
data-x="concept-environment-execution-ready-flag">execution ready flag</span>.</p></li>

<!-- SCRIPT EXEC -->

<li>
Expand Down