Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shared workers always key on constructor url and name #175

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 22, 2015

This matches Firefox, simplifies the model, and removes the need for
URLMismatchError.

Fixes part of #164.

@annevk
Copy link
Member Author

annevk commented Sep 22, 2015

It would be ideal if someone from Chromium could sign off on this. E.g., @kinu, @sof, or whoever else feels responsible.

@kinu
Copy link

kinu commented Sep 22, 2015

I feel this change makes sense; I agree that current URLMismatchError behavior is somewhat confusing. /cc @horo-t

This matches Firefox, simplifies the model, and removes the need for
URLMismatchError.

Fixes part of #164.
@domenic domenic merged commit b261d16 into master Sep 23, 2015
@domenic domenic deleted the urlmismatcherror branch September 23, 2015 20:08
@kinu
Copy link

kinu commented Oct 3, 2015

For chromium tracked at: http://crbug.com/538914

annevk added a commit to web-platform-tests/wpt that referenced this pull request Oct 10, 2016
zcorpan pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants