Make <link rel="stylesheet"> work inside shadow trees #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
normative change
topic: shadow
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Feb 12, 2021
When Shadow DOM was first considered for use in the client `<link rel="stylesheet">` was not widely supported as a way to load external styles into shadow roots. This was resolved in the spec in whatwg/html#1572 and has now long been supported by all browsers. Using `<link>` simplifies the code and also avoids a possible problem with sites that have a strict CSP policy that disallows inline styles. In the browser extension context a `<link>` can still work in that scenario as long as the stylesheet is loaded from a `chrome-extension://` URL.
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Feb 12, 2021
When Shadow DOM was first considered for use in the client `<link rel="stylesheet">` was not widely supported as a way to load external styles into shadow roots. This was resolved in the spec in whatwg/html#1572 and has now long been supported by all browsers. Using `<link>` simplifies the code and also avoids a possible problem with sites that have a strict CSP policy that disallows inline styles. In the browser extension context a `<link>` can still work in that scenario as long as the stylesheet is loaded from a `chrome-extension://` URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WICG/webcomponents#530.