-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'creator context security'. #1561
Conversation
context</span> (<var>creator</var>), it also has the following properties whose values are set | ||
with regard to <var>creator</var>'s <span>active document</span> at the time <var>context</var> | ||
is created (<var>creator document</var>):</p> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Here's how I would phrase this:
If a browsing context context has a creator browsing context creator, it also has the following properties. In what follows, let creator document be creator's active document at the time context is created.
Looks good overall, with editorial nits again. When we merge this we'll want to reference #987 in the commit message to explain why "creator Document" is gone. |
Monkey-patches bad. Upstreaming good. Closes w3c/webappsec-secure-contexts#31.
is created (<var>creator document</var>):</p> | ||
context</span> (<var>creator</var>), it also has the following properties. In what follows, let | ||
<var>creator document</var> be <var>creator</var>'s <span>active document</span> at the time | ||
<var>context</var> is created (<var>creator document</var>):</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the parentheses? Also "(creator document)" is now redundant.
Dropped |
Secure Contexts relied on 'creator Document', which was removed in #987. This patch caches the security status of that Document for the new browsing context's security checks. w3c/webappsec-secure-contexts#37
(Also added the reference to the PR which dropped the |
Secure Contexts relied on 'creator Document', which no longer exists. This patch
caches the security status of that Document for the new browsing context's
security checks.
w3c/webappsec-secure-contexts#37