Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'creator context security'. #1561

Merged
merged 2 commits into from
Jul 15, 2016
Merged

Add 'creator context security'. #1561

merged 2 commits into from
Jul 15, 2016

Conversation

mikewest
Copy link
Member

Secure Contexts relied on 'creator Document', which no longer exists. This patch
caches the security status of that Document for the new browsing context's
security checks.

w3c/webappsec-secure-contexts#37

@mikewest
Copy link
Member Author

@domenic, @foolip: Note that this PR relies on the other PR (#1560). So ignore the first commit here, and focus on the second, please. :)

context</span> (<var>creator</var>), it also has the following properties whose values are set
with regard to <var>creator</var>'s <span>active document</span> at the time <var>context</var>
is created (<var>creator document</var>):</p>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Here's how I would phrase this:

If a browsing context context has a creator browsing context creator, it also has the following properties. In what follows, let creator document be creator's active document at the time context is created.

@domenic
Copy link
Member

domenic commented Jul 15, 2016

Looks good overall, with editorial nits again.

When we merge this we'll want to reference #987 in the commit message to explain why "creator Document" is gone.

@mikewest
Copy link
Member Author

d7d5ecf has some fixup changes based on your feedback. If you're happy, I'll squish them down and change the commit message to include #987.

is created (<var>creator document</var>):</p>
context</span> (<var>creator</var>), it also has the following properties. In what follows, let
<var>creator document</var> be <var>creator</var>'s <span>active document</span> at the time
<var>context</var> is created (<var>creator document</var>):</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the parentheses? Also "(creator document)" is now redundant.

@mikewest
Copy link
Member Author

Dropped () (though, personally, I like the way they visually set the variable name apart from the rest of the text), the redundant <var>, and squished.

Secure Contexts relied on 'creator Document', which was removed in
#987. This patch caches the security status of that
Document for the new browsing context's security checks.

w3c/webappsec-secure-contexts#37
@mikewest
Copy link
Member Author

(Also added the reference to the PR which dropped the creator Document concept to the patch description. Thanks for tracking that down for me! :) )

@domenic domenic merged commit 91f1919 into whatwg:master Jul 15, 2016
@mikewest mikewest deleted the creator branch July 18, 2016 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants