-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove XMLDocument.prototype.load #1478
Conversation
oh, yes, we should get rid of the horrible .load. |
Edge does not. |
I think this might also allow us to make XMLDocument an alias of Document, like HTMLDocument is supposedly specced as... |
Do we still need |
565 matches. So at least it should be an alias, but possibly it needs to stay as separate (if a script adds something to |
This is only implemented in Gecko, and is long-deprecated.
8f8dec0
to
c9dc776
Compare
whatwg/html#1478 removed that feature from the HTML Standard.
In https://bugzilla.mozilla.org/show_bug.cgi?id=983090, bz mentioned xmlDoc = new ActiveXObject("Microsoft.XMLDOM")
xmlDoc.load(whatever); Did you test that in IE? |
Results in an error in Edge, "'ActiveXObject' is undefined". |
FYI, as far as I know, WebKit does not support this and we do not have plans to support it either. |
Note that there is code out there that does browser sniffing and would break in browsers it does not sniff as "WebKit" that don't have |
And note that the current spec was written precisely in a way that would allow all UAs to implement it and be compatible with known existing content... That's what https://www.w3.org/Bugs/Public/show_bug.cgi?id=14037 was all about. |
I guess we could add this to Gecko compatibility mode... |
Could we add some comments to the spec source code to prevent this kind of issues. |
Yes, I think that adding comments is definitely the correct way to handle this sort of thing. So Mozilla would prefer we add this back in Gecko compatibility mode? I assume that'd be easier than trying to do telemetry to see if things have changed since 2011. |
I'm not sure I have a strong preference for whether this should be added in the compat mode or just as a spec note or something, but I do want the spec to document reality so new engine implementors are not lead astray... |
Well, new engine implementers should not implement XMLDocument.prototype.load, so I'm not sure what the issue is there... |
Then new engine implementers need to have a UA string that will sniff as "WebKit" by the relevant libraries and need to implement a bunch of webkit-prefixed stuff. Does the spec document that? |
That's fair. It sounds like Gecko compatibility mode would be the best place to document this, then. |
If we drop XMLDocument.prototype.load, do we still need XMLDocument? XMLDocument brings nothing beside load(). |
@cdumez could you comment on whatwg/dom#278 instead? And maybe indicate what the status is in WebKit? It sounds like Gecko needs to keep the distinction around... And developers might have used |
This is only implemented in Gecko, and is long-deprecated.
@smaug----, any objections? I notice it was deprecated in Gecko in https://bugzilla.mozilla.org/show_bug.cgi?id=494705. I'm happy to file a removal bug.