Make <style> work in shadow trees #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a longstanding issue that was pointed out in a comment, that <style> elements work regardless of whether their node document is associated with a browsing context. Also perform the cleanup requested in the source.
|
FYI, @hayatoito, @rniwa, @smaug----. |
|
Looks good to me. |
|
LGTM |
| @@ -13924,16 +13918,14 @@ own thing rather than part of the extended sentence --> | |||
| <li><p>If <var>element</var> has an <span>associated CSS style sheet</span>, <span | |||
| data-x="remove a CSS style sheet">remove the CSS style sheet</span> in question.</p></li> | |||
|
|
|||
| <li><p>If <var>element</var> is not <span>in a <code>Document</code></span>, then abort | |||
| these steps.</p></li> <!-- http://software.hixie.ch/utilities/js/live-dom-viewer/saved/2740 --> | |||
| <li><p>If <var>element</var> is not <span>in a shadow-including document</span>, then abort these | |||
There was a problem hiding this comment.
This would mean that shadowRoot.stylesheets would not include a stylesheet when the shadow root is disconnected from a document. That doesn't reflect what we discussed in WICG/webcomponents#56.
It looks like we need a separate bug for CSS OM as well: https://drafts.csswg.org/cssom/#extensions-to-the-document-interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a longstanding issue that was pointed out in a comment, that
<style>elements work regardless of whether their node document isassociated with a browsing context.
Also perform the cleanup requested in the source.