Don't update document.currentScript for module scripts

[domenic]

Closes #997.

[annevk]

See #997 (comment) for feedback.

[domenic]

Updated

[annevk]

I think if the module script is the reentrant script we'd want it to be set to null too, no? Or can that never happen with module scripts?

[domenic]

Are you talking about updating the non-normative note?

[annevk]

I meant that rather than only updating it for classic scripts, we should update it for module scripts too, but just set it to null, and once the script is executed restore the previous value.

[domenic]

Oh, interesting. I felt like just ignoring currentScript would be better, but that's probably reasonable behavior too.

I think reentrancy can happen for async module scripts with no dependencies.

[annevk]

We should probably also add a note explaining why it's null.

[domenic]

Pushed the new set-to-null semantics.

I'm not sure what kind of note we could add, besides "because we don't like this API any more". I'd welcome a suggestion.

[annevk]

I guess we could remove the "domintro" box, mark it "// historical" in IDL, and add "This API fell out of fashion as it globally exposes script and SVG script element. The JavaScript community is looking for a way to identify these without making them globally available." as a note underneath the normative definition.

[domenic]

I think that's not a great idea verbatim, as whatever we come up with will only work for module scripts anyway. Maybe... keep domintro, mark it // classic scripts only in IDL, and add "This API fell out of fashion as it globally exposes script and SVG script elements. As such, it is not available in newer contexts, such as when running module scripts or when running scripts in a shadow tree. The JavaScript community is looking into a new solution for identifying the running script in such contexts, which does not make it globally available."

[annevk]

"classic scripts in a document only" then if we're mentioning shadow trees. But that seems fine. Do you want me to patch things up?

[domenic]

I can do it when I get to work.

[domenic]

Added a fixup commit