Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should location.search use the document encoding? #8308

Closed
annevk opened this issue Sep 22, 2022 · 2 comments · Fixed by #8309
Closed

Should location.search use the document encoding? #8308

annevk opened this issue Sep 22, 2022 · 2 comments · Fixed by #8309
Labels
interop Implementations are not interoperable with each other normative change topic: navigation

Comments

@annevk
Copy link
Member

annevk commented Sep 22, 2022 •
edited
Loading

Back in 2018 I worked on web-platform-tests/wpt#10891 and I didn't really question whether this is something we wanted to change, but both Chrome and Safari getting away with not passing on the document encoding (and thus using UTF-8) makes me wonder if we should just align on that instead as it's slightly simpler and requires less engines to change.

@valenting thoughts?

Related bugs:
@annevk annevk added normative change topic: navigation interop Implementations are not interoperable with each other labels Sep 22, 2022
@valenting
Copy link

Good question. It definitely prefer UTF-8.
If Chrome & Safari have been able to get away with it, I think it's a very niche use case, and we can probably align with that.

annevk added a commit to web-platform-tests/wpt that referenced this issue Sep 22, 2022
@annevk
Make location.search always expect UTF-8
88f2064 
Helps whatwg/html#8308 and forthcoming PR.
@annevk annevk mentioned this issue Sep 22, 2022
Merged
annevk added a commit that referenced this issue Sep 22, 2022
@annevk
Make location.search use UTF-8 unconditionally
8e0d14f 
Tests: web-platform-tests/wpt#36019.

Fixes #8308.
@annevk annevk mentioned this issue Sep 22, 2022
Merged
3 tasks
@annevk
Copy link
Member Author

annevk commented Sep 22, 2022

There's a PR at #8309 now as well as a PR for the tests. If another HTML editor agrees we'll deploy this change.

annevk added a commit that referenced this issue Sep 22, 2022
@annevk
Make location.search use UTF-8 unconditionally
329b358 
Tests: web-platform-tests/wpt#36019.

Fixes #8308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interop Implementations are not interoperable with each other normative change topic: navigation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make location.search use UTF-8 unconditionally whatwg/html
2 participants
@valenting @annevk