Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event loop's last idle period start time is never set #7765

Closed
skyrising opened this issue Mar 30, 2022 · 2 comments · Fixed by #7772
Closed

Event loop's last idle period start time is never set #7765

skyrising opened this issue Mar 30, 2022 · 2 comments · Fixed by #7772
Labels
topic: event loop

Comments

@skyrising
Copy link

https://html.spec.whatwg.org/commit-snapshots/89f9bcb6edae0b619e074dd67c9fd031bc86ab9f/#idle-deadline-computation

Let deadline be this event loop's last idle period start time plus 50.

I can't find any mention of when this value should be updated, meaning deadline would always be the initial value 0 plus 50.
@domenic
Copy link
Member

domenic commented Mar 31, 2022

@noamr I think this is from work you did, right? What's the correct fix here?

noamr added a commit to noamr/html that referenced this issue Mar 31, 2022
@noamr
Set idle period start time
ebd41c8 
Closes whatwg#7765
@noamr noamr mentioned this issue Mar 31, 2022
Merged
3 tasks
@noamr
Copy link
Contributor

noamr commented Mar 31, 2022

@noamr I think this is from work you did, right? What's the correct fix here?

Yea I think this line got lost when I refactored that period to be associated with the event loop. :(
The fix is simple: #7772

domenic pushed a commit that referenced this issue Mar 31, 2022
@noamr
Fix tracking of the idle period start time
4c6e6f1 
This was accidentally omitted from bd63843.

Closes #7765.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@noamr @mfreed7
Fix tracking of the idle period start time
cd4f077 
This was accidentally omitted from bd63843.

Closes whatwg#7765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: event loop
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Set idle period start time noamr/html
3 participants
@noamr @domenic @skyrising