Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage use of document.domain #5128

Closed
zcorpan opened this issue Dec 5, 2019 · 4 comments · Fixed by #5714
Closed

Discourage use of document.domain #5128

zcorpan opened this issue Dec 5, 2019 · 4 comments · Fixed by #5714
Assignees
@domenic
Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation removal/deprecation Removing or deprecating a feature topic: origin

Comments

@zcorpan
Copy link
Member

zcorpan commented Dec 5, 2019

https://html.spec.whatwg.org/multipage/origin.html#dom-document-domain

In the context of #5122 it struck me that the spec and MDN doesn't discourage use of document.domain or explain why it's bad and what web developers should do instead to communicate across origins.

cc @whatwg/security
@zcorpan zcorpan added removal/deprecation Removing or deprecating a feature topic: origin labels Dec 5, 2019
@mozfreddyb
Copy link
Contributor

I agree there should be stronger wording to discourage its use.

@zcorpan
Copy link
Member Author

zcorpan commented Dec 5, 2019

I've also filed https://bugs.chromium.org/p/chromium/issues/detail?id=1031069 to add a warning in devtools console.

@mozfreddyb
Copy link
Contributor

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1601644

@sideshowbarker
Copy link
Contributor

@whatwg/documentation

@sideshowbarker sideshowbarker added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Dec 28, 2019
domenic added a commit that referenced this issue Jul 8, 2020
@domenic
Various updates to the document.domain section
d60cfdc 
* Expand the previous warning, and make it more prominent. Closes #5128.

* Update the algorithm steps to modern Web IDL style.

* Update the domintro by incorporating the note on what it does, and
  describing failure cases in more detail.

* Move the helper algorithm below the getter/setter steps.
@domenic domenic mentioned this issue Jul 8, 2020
Merged
@domenic domenic self-assigned this Jul 8, 2020
domenic added a commit that referenced this issue Jul 10, 2020
@domenic
Various updates to the document.domain section
b868520 
* Expand the previous warning, and make it more prominent. Closes #5128.

* Update the algorithm steps to modern Web IDL style.

* Update the domintro by incorporating the note on what it does, and
  describing failure cases in more detail.

* Move the helper algorithm below the getter/setter steps.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 11, 2020
@domenic @mfreed7
Various updates to the document.domain section
2473690 
* Expand the previous warning, and make it more prominent. Closes whatwg#5128.

* Update the algorithm steps to modern Web IDL style.

* Update the domintro by incorporating the note on what it does, and
  describing failure cases in more detail.

* Move the helper algorithm below the getter/setter steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation removal/deprecation Removing or deprecating a feature topic: origin
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various updates to the document.domain section whatwg/html
4 participants
@sideshowbarker @zcorpan @domenic @mozfreddyb