Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What object is CustomElementRegistry associated with #2578

Closed
annevk opened this issue Apr 24, 2017 · 4 comments
Closed

What object is CustomElementRegistry associated with #2578

annevk opened this issue Apr 24, 2017 · 4 comments
Assignees
Labels
interop Implementations are not interoperable with each other topic: custom elements Relates to custom elements (as defined in DOM and HTML)

Comments

@annevk
Copy link
Member

annevk commented Apr 24, 2017

Previously: #2545, #2566. Basic test, fails in Chrome and Safari:

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<iframe></iframe>
<script>
async_test(t => {
  const frameCE = self[0].customElements
  self[0].frameElement.onload = t.step_func_done(() => {
    assert_equals(self[0].customElements, frameCE)
  })
  self[0].location.href = "/common/blank.html"
})
</script>
@annevk annevk added interop Implementations are not interoperable with each other topic: custom elements Relates to custom elements (as defined in DOM and HTML) labels Apr 24, 2017
@domenic
Copy link
Member

domenic commented Apr 24, 2017

The spec is very clear on this. I will submit a web platform test and file bugs.

@domenic
Copy link
Member

domenic commented Apr 24, 2017

Hmm, this test may be being confused by #490.

@domenic
Copy link
Member

domenic commented Apr 25, 2017

We should probably collaborate on a shared set of test helpers for "is tied to Window". So e.g. we have web-platform-tests/wpt#5681 but we should also test the issue discovered in #2579 (removing iframes). We can have a shared test helper that generates 3+ tests and then separate test files that test each property.

domenic added a commit to web-platform-tests/wpt that referenced this issue May 1, 2017
domenic added a commit to web-platform-tests/wpt that referenced this issue May 2, 2017
@domenic
Copy link
Member

domenic commented May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other topic: custom elements Relates to custom elements (as defined in DOM and HTML)
Development

No branches or pull requests

2 participants