-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default styling of <rp> #2134
Comments
From the spec:
This is not internally consistent, so that should be fixed (regardless of which UA style we decide on). |
I'm fine with Edge or Gecko. Thank you for your investigations. |
I'd prefer Gecko's current behavior, but I don't have strong opinion against Edge's, so if the webcompat impact is reasonable, I'm fine with Edge's behavior. I have one concern that, per CSS Ruby spec, Another edge case would be using inline-blocks inside ruby, then its descendant |
The anonymous box case sounds reasonable. @zcorpan do we know someone to ask the opinion from Edge on this topic? |
Using Using the CSS ruby model with anonymous boxes is fine, but that has nothing to do with using the While it is reasonable to think that it is expected that an
If the author explicitly sets cc @gregwhitworth for opinions from Edge. |
I propose closing this issue as no change. We currently have interop across Gecko and Blink, I can't think of a use case for anything more complicated, and it's the simplest and most performant of the options presented. |
Ah, so Blink changed something since #2134 (comment)? Sounds good. Does Safari need a bug? |
Yes, crbug.com/859416 in 2018. |
cc @rniwa |
This test covers this (through
|
It seems we don't have interop on the default style of
rp
.Tests:
http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4711
http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4714
'display' is...
<p><ruby><rp>
<p><ruby><rtc><rp>
<p><ruby><span><rp>
<p><rp>
<p><ruby><rp style="display: inline-block">
That is, we have these UA stylesheets:
ruby rp { display: none; }
ruby > rp { display: none; }
rp { display: none; }
ruby rp { display: none !important; }
rp { display: none !important; }
Currently the spec says Gecko, IE 10..11 are correct.
In httparchive, looking for pages that have
<rp>
but no<ruby>
, I found a single page that is "broken" in Gecko but not in the others:http://www.kerala.com/ has
(The cufon thing inserts a
canvas
into therp
to render some glyph.)The Blink and WebKit default style seems incompatible with
rtc
(#121). Gecko is simplest, but it is the only engine now to hiderp
outsideruby
, and it breaks at least the page above. Should we switch to the behavior of Edge 13?cc @upsuper @yosinch @kojiishi @rniwa
The text was updated successfully, but these errors were encountered: