Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the object element's name attribute need not propagate to the nested browsing context #1623

Closed
foolip opened this issue Aug 2, 2016 · 4 comments

Comments

@foolip
Copy link
Member

foolip commented Aug 2, 2016

Context:
https://bugs.chromium.org/p/chromium/issues/detail?id=632243

https://html.spec.whatwg.org/#the-object-element:attr-object-name-3 says "Whenever the name attribute is set, if the object element has a nested browsing context, its name must be changed to the new value. If the attribute is removed, if the object element has a browsing context, the browsing context name must be set to the empty string."

Here's an ad-hoc test:
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/4353

No tested browser seems to do what the spec suggests here, so can it be dropped?

@foolip
Copy link
Member Author

foolip commented Aug 2, 2016

@xiaojunwu, you added the test in question in xiaojunwu/web-platform-tests@5e02231, any thoughts?

@annevk
Copy link
Member

annevk commented Aug 4, 2016

So <object> behaves the same as <embed> in practice? There's a whole bunch of bugs around these elements and their processing model needing to be more identical...

@foolip
Copy link
Member Author

foolip commented Aug 12, 2016

There appears to be some differences that involve the name attribute still in Blink, just not the one about propagation. Namely, object is a form-associated element where embed is not, but that's in the spec:
https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
https://html.spec.whatwg.org/multipage/embedded-content.html#the-object-element

I'm sure there are more quirky things hiding here, but I'll prepare a PR to drop the bit in question at least.

@foolip
Copy link
Member Author

foolip commented Aug 12, 2016

I went and found the commit where this was added: 0a2ab22

Here's a test of that "allow to load stuff in them" bit:
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/4374

In Chrome, Edge and Firefox, "open in iframe" works but "open in object" just opens a new tab. So this thing didn't become reality, time to drop.

foolip added a commit that referenced this issue Aug 12, 2016
Introduced with 0a2ab22, but it appears
that <object name> as a target for <a target> was never implemented.

Fixes #1623.
domenic pushed a commit that referenced this issue Aug 12, 2016
Introduced with 0a2ab22, but it appears
that <object name> as a target for <a target> was never implemented.

Fixes #1623.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
Introduced with 0a2ab22, but it appears
that <object name> as a target for <a target> was never implemented.

Fixes whatwg#1623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants