Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to define the source thing (browsing context or not) for iframe loads #1131

Closed
bzbarsky opened this issue Apr 26, 2016 · 2 comments · Fixed by #1171
Closed

Need to define the source thing (browsing context or not) for iframe loads #1131

bzbarsky opened this issue Apr 26, 2016 · 2 comments · Fixed by #1171
Labels
topic: navigation

Comments

@bzbarsky
Copy link
Contributor

<object> loads say things like this:

If the URL of the given resource is not about:blank, the element's nested browsing context must then be navigated to that resource, with replacement enabled, and with the object element's node document's browsing context as the source browsing context.

In comparison, https://html.spec.whatwg.org/multipage/embedded-content.html#otherwise-steps-for-iframe-or-frame-elements says:

Navigate the element's child browsing context to url.

with no mention of what the source browsing context is. now the concept of source browsing context is broken, per #1130, but we should be indicating what the source document or whatever is here; presumably the node document of the iframe or frame element?
@bzbarsky bzbarsky mentioned this issue Apr 26, 2016
Closed
annevk added a commit that referenced this issue May 3, 2016
@annevk
Regression: define source browsing context for iframe and frame
d57c4c6 
1490eba, from PR #484, removed the
source browsing context definition along with "explicit
self-navigation override". This restores the definition of source
browsing context for these elements as it was before that commit.

This fixes #1131, but note that per #1130 further changes are
required here, as browsing contexts are not a good concept to use as
source.
@annevk annevk mentioned this issue May 3, 2016
Merged
@annevk
Copy link
Member

annevk commented May 3, 2016

This is a regression. I posted a PR to fix this without touching #1130 for now as that seems to require quite a bit of effort.

domenic pushed a commit that referenced this issue May 3, 2016
@annevk @domenic
Regression fix: define source browsing context for iframe and frame
a714902 
1490eba, from PR #484, removed the
source browsing context definition while removing the "explicit
self-navigation override". This restores the definition of source
browsing context for these elements as it was before that commit.

This fixes #1131, but note that per #1130 further changes are
required here, as browsing contexts are not a good concept to use as
source.
@annevk
Copy link
Member

annevk commented May 3, 2016

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: navigation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regression: define source browsing context for iframe and frame whatwg/html
3 participants
@domenic @bzbarsky @annevk