Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: enable snapshots #73

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Meta: enable snapshots #73

merged 1 commit into from
Jan 13, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 12, 2017

No description provided.

@annevk annevk mentioned this pull request Jan 12, 2017
Closed
6 tasks
@annevk
Copy link
Member Author

annevk commented Jan 12, 2017

@foolip @upsuper this PR basically changes nothing. The only problem is that once we land it existing PRs will need to be rebased and no longer include the HTML output. Let me know if that's a problem and I can hold off for a bit.

foolip
foolip approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the scripts were copied from elsewhere and don't need much scrutiny. I'll rebase my PRs, no problem!

@annevk annevk merged commit 8130c44 into master Jan 13, 2017
@annevk annevk deleted the annevk/snapshots branch January 13, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @foolip