Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define what happens with requestFullscreen() and exitFullscreen() in inactive document #67

Closed
foolip opened this issue Dec 15, 2016 · 5 comments
Closed

Define what happens with requestFullscreen() and exitFullscreen() in inactive document #67

foolip opened this issue Dec 15, 2016 · 5 comments

Comments

@foolip
Copy link
Member

foolip commented Dec 15, 2016

From @zcorpan in https://bugs.chromium.org/p/chromium/issues/detail?id=674454

I don't think we should fire any events, because I don't know how to implement it. (In Blink, in an inactive document, events are just dropped on the ground.)

Just rejecting the promise would work, though.

Also need to define what happens if the document becomes inactive between the request and the animation frame task.
@zcorpan
Copy link
Member

zcorpan commented Dec 15, 2016

Oh right, the event loop doesn't spin in inactive documents. We can still queue to fire the event, though. If the document becomes active again, it would be fired at that time, right?

@foolip
Copy link
Member Author

foolip commented Dec 15, 2016

Is that if one navigates back and forward?

@zcorpan zcorpan mentioned this issue Dec 15, 2016
Merged
@zcorpan
Copy link
Member

zcorpan commented Dec 15, 2016

Yeah. Or just navigate to a new doc, request fullscreen in the inactive doc, then navigate back.

@foolip
Copy link
Member Author

foolip commented Dec 15, 2016

So for requestFullscreen() is this covered by "If document's browsing context's active document is not document, then return false." in https://html.spec.whatwg.org/multipage/embedded-content.html#allowed-to-use?

foolip added a commit that referenced this issue Dec 15, 2016
@foolip
Reject exitFullscreen() in inactive documents
71bee0f 
If the document becomes inactive after the request, then there will not
be another animation frame task, in which case the promise will be left
hanging instead.

Fixes #67.
@foolip foolip mentioned this issue Dec 15, 2016
Merged
@zcorpan
Copy link
Member

zcorpan commented Dec 15, 2016

Yes.

foolip added a commit that referenced this issue Dec 15, 2016
@foolip
Reject exitFullscreen() in inactive documents
9dca74d 
If the document becomes inactive after the request, then there will not
be another animation frame task, in which case the promise will be left
hanging instead.

Fixes #67.
foolip added a commit that referenced this issue Dec 16, 2016
@foolip
Reject exitFullscreen() in inactive documents
64f2487 
If the document becomes inactive after the request, then there will not
be another animation frame task, in which case the promise will be left
hanging instead.

Fixes #67.
annevk pushed a commit that referenced this issue Dec 16, 2016
@foolip @annevk
Reject exitFullscreen() in inactive documents
59574a4 
If the document becomes inactive after the request, then there will not
be another animation frame task, in which case the promise will be left
hanging instead.

Test: web-platform-tests/wpt#4350.

Fixes #67.
@tzik tzik mentioned this issue Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @foolip