-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: use origin-based "same site" definition #965
Conversation
I think the goal will be to change our collective behavior such that we take the scheme into account for mechanisms that work through today's "same site" concept. So yes, today it's a mismatch. Tomorrow, it ideally won't be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The second bullet point which you did not touch is important here and follows from a suggestion by @youennf in #687 (comment), also supported by @arturjanc and @johnwilander at the time. Soon those mixed content images will no longer be requested over HTTP though so I think we can indeed simplify this, but that means two things for this PR:
|
OK, I think I changed this as people were suggesting. However I'm a bit unsure whether or how we should tie this up with the updates for whatwg/url#448. Any guidance would be appreciated. To be clear, I was mostly hoping to make editorial changes with this effort, and would rather not sign up for e.g. updating web platform tests for CORP, if we're making normative changes to its behavior. |
In that case you should replace same site with schemelessly same site in the existing text and we can file a follow-up to consider making this stricter (which would then end up with the simplified text). |
Ok, and keep the second bullet point? In that case I think it's just a revert of my second commit, right? |
Well, and s/same site/schemelessly same site/ as that was what same site used to do. |
This reverts commit f290b62.
OK cool, this should be ready to merge when the Bikeshed link database updates. Commit message:
|
Follows whatwg/html#5076.
/cc @mikewest
I'm unsure whether this should be "same site" or "schemelessly same site". I guess for parity with the previous it should be "schemelessly same site"? But that seems like a pretty bad mismatch with the web-dev-visible header name... what's going on?
Preview | Diff