Add Request's isHistoryNavigation #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Apr 27, 2018
annevk
added
needs tests
This was referenced May 8, 2018
annevk
reviewed
May 25, 2018
| <dfn export for=request id=concept-request-history-navigation-flag>history-navigation flag</dfn>. | ||
| Unless stated otherwise, it is unset. | ||
|
|
||
| <p class="note no-backref">This flag is for exclusive use by HTML's navigate algorithm. [[!HTML]] |
There was a problem hiding this comment.
We should move this and the flag before it, up a bit. See #732. Sorry for not noticing that earlier. I can probably take care of this as a fixup commit once everything is close to landing, but I'm also happy for you to take care of it.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
May 25, 2018
See w3c/ServiceWorker#1167 for the discussion that led to this change and whatwg/fetch#718 for the infrastructure in Fetch this builds upon. Also includes minor editorial changes to the "traverse the history" algorithm. Tests: web-platform-tests/wpt#10909
yutakahirano
force-pushed
the
yhirano/history-navigation
branch
from
c2e2d64
to
1bf4007
Compare
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 29, 2018
See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167.
annevk
removed
do not merge yet
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2018
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Jun 12, 2018
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
See w3c/ServiceWorker#1167 for the discussion that led to this change and whatwg/fetch#718 for the infrastructure in Fetch this builds upon. Also includes minor editorial changes to the "traverse the history" algorithm. Tests: web-platform-tests/wpt#10909
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also a member on the request concept (history-navigation flag) to support this API. See w3c/ServiceWorker#1167 for the discussion that led to this.
Tests: web-platform-tests/wpt#10909
Corresponding HTML change: whatwg/html#3674
Preview | Diff