Block additional script MIMETypes (audio, video, csv) #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup. Assuming the numbers you noted in the other bug stays stable through the release train, I'd like to do the same in Chrome. |
| @@ -1498,7 +1498,9 @@ <h3 id="should-response-to-request-be-blocked-due-to-mime-type?"><dfn title="sho | |||
| <li><p>Let <var>type</var> be <var>request</var>'s <span title=concept-request-type>type</span>. | |||
|
|
|||
| <li><p>If <var>type</var> is "<code title>script</code>", and <var>MIMEType</var> starts with | |||
| `<code title>image/</code>`, then return <b title>blocked</b>. | |||
| `<code title>audio/</code>`, `<code title>image/</code>` or `<code title>video/</code>`, then return <b title>blocked</b>. | |||
There was a problem hiding this comment.
Nit: I like Oxford commas ("audio, image, or ...").
|
Please also add yourself to the acknowledgments. If it's all too much hassle, let me know and I'll handle the nits. |
|
Thanks for the quick feedback! I tried to fix your comments, but I am quite sure if I should use the |
annevk
pushed a commit
that referenced
this pull request
Aug 31, 2016
When request's type is "script", this will make sure we also block MIME types starting with "audio/" or "video/", or MIME types that are text/csv. Due to browsers not paying any attention to "script" MIME types this is blocklist-based, but it's better than nothing. (Use `X-Content-Type-Options: nosniff` to make it safelist-based.) PR: #379
|
Ta, landed as 2e85cef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337.
I also added audio/video, because per telemetry they are probably unused. I think it makes sense to block them alongside of
image/.text/csvis blocked to mitigate the issue described in Bug 1048535.@mikewest Are you on board with this?