Formalize reading bodies #1172
Merged
Formalize reading bodies #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
do not merge yet
annevk
commented
Feb 17, 2021
annevk
force-pushed
the
annevk/read-body
branch
from
672ed2e to
c9fe740
Compare
|
I think this is getting somewhere, but:
It makes things more verbose for sure, but overall I think that is probably worth it. Early takes from @yutakahirano and @jakearchibald would also be welcome with regards to that. |
domenic
reviewed
Feb 18, 2021
annevk
added a commit
to w3c/webappsec-subresource-integrity
that referenced
this pull request
Feb 19, 2021
Corresponding Fetch PR: whatwg/fetch#1172. Closes #63. Helps with #83.
domenic
approved these changes
Feb 19, 2021
| <li><p>Set <var>request</var>'s <a for=request>body</a> to <var>body</var>. | ||
| </ol> | ||
| <li><p>If <var>request</var>'s <a for=request>body</a> is a <a for=/>byte sequence</a>, then set | ||
| <var>request</var>'s <a for=request>body</a> to the first return value of |
There was a problem hiding this comment.
"the first return value" seems pretty unusual; why not just "the result of"? Here and below.
There was a problem hiding this comment.
It returns two values. I'm aligning it with text elsewhere that uses this terminology.
annevk
force-pushed
the
annevk/read-body
branch
from
9b06fa3 to
2c36ccb
Compare
|
Thanks, I addressed those comments. I also updated the first commit to include a longer description of the changes. |
annevk
added a commit
to w3c/webappsec-subresource-integrity
that referenced
this pull request
Feb 22, 2021
Corresponding Fetch PR: whatwg/fetch#1172. Closes #63. Helps with #83.
This refactoring allows specifications building on top of Fetch to avoid having to directly integrate with Streams. It makes these changes: * body's transmitted bytes is removed. body's total bytes will likely be removed in #604. * body's done and wait concepts are removed. * It introduces three primitives to read a body: incrementally read (process each chunk), fully read (get all), and fully reading body as promise (get all as promise). * Removed transmit request body in favor of HTTP-network fetch using incrementally read directly to transmit the request body. * Fetch's processRequestBody and processRequestEndOfBody are no longer passed a request. The former is passed the chunk length for progress reporting. (Needed by XMLHttpRequest.) * Fetch's processResponseEndOfBody when passed will now cause the body to be fully read and will pass the result in the second argument. (This means that callers can no longer read the body themselves.) * Subresource Integrity changed slightly with Fetch handing it the bytes and integrity metadata and no longer a response. Essentially fetch fully reads the body, does the check, and then creates a new body from the same bytes to hand to the caller. Subresoruce Integrity PR: w3c/webappsec-subresource-integrity#97. XMLHttpRequest PR: whatwg/xhr#313. Closes #661.
annevk
force-pushed
the
annevk/read-body
branch
from
2c36ccb to
cd84104
Compare
annevk
removed
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661.
Preview | Diff