Clarify the usage the output I/O queues in the hooks #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An "output" parameter was added to the hooks for standards in #215, but no explanation was given as to why it was needed. This change adds that clarification.
This was referenced Sep 17, 2020
annevk
reviewed
Sep 21, 2020
There was a problem hiding this comment.
Thanks, looks good modulo nit. This isn't editorial per https://github.com/whatwg/meta/blob/master/COMMITTING.md. I do wonder if we should have something for these kind of changes as most folks would probably want to skip them too.
andreubotella
changed the title
|
In that case I've misunderstood what editorial means all along! 😅 Feel free to change the commit message when merging, then. |
annevk
approved these changes
Sep 21, 2020
sideshowbarker
added a commit
to validator/validator
that referenced
this pull request
Sep 21, 2020
This change is a hack to work around the fact the CSS-checking backend doesn’t yet have support for the color-scheme property — and it’s not clear that it should have such support at this point, because the color-scheme property isn’t actually supported yet in any engine other than Blink. So for now, this change causes the checker to filter out (drop/ignore/suppress) any error messages about `color-scheme` values. Related to whatwg/encoding#230 Related to whatwg/meta#188 Related to w3c/css-validator#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "output" parameter was added to the hooks for standards in #215, but no explanation was given as to why it was needed. This change adds that clarification.
Preview | Diff