Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is-available-to-element-internals #893

Merged
merged 6 commits into from
Oct 5, 2020

Conversation

mfreed7
Copy link
Contributor

@mfreed7 mfreed7 commented Sep 15, 2020

Add "is available to element internals" flag, for use with the accompanying HTML PR which restricts access to ElementInternals.shadowRoot for shadow roots which were pre-existing before a custom element upgrade/construction. See the discussion on Issue 871 for more context.


Preview | Diff

dom.bs Outdated Show resolved Hide resolved
dom.bs Outdated Show resolved Hide resolved
dom.bs Outdated Show resolved Hide resolved
mfreed7 and others added 2 commits September 28, 2020 09:10
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails because csswg.org is down (which hosts part of the build pipeline), but I guess we're waiting for the HTML side here anyway.

@mfreed7
Copy link
Contributor Author

mfreed7 commented Sep 28, 2020

Build fails because csswg.org is down (which hosts part of the build pipeline), but I guess we're waiting for the HTML side here anyway.

Ahh ok, thanks. I was wondering what was broken there.

Let me know what changes you want to see on the HTML side. I addressed a few comments from rniwa already.

@domenic
Copy link
Member

domenic commented Oct 5, 2020

The build is still failing because of trailing whitespace. I'll try to fixup and get this merged...

@domenic domenic merged commit 8c0049e into whatwg:master Oct 5, 2020
@mfreed7
Copy link
Contributor Author

mfreed7 commented Oct 5, 2020

Thanks for the help on all of these PRs!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 10, 2021
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants