Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Infra's concatenation definition #556

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Use Infra's concatenation definition #556

merged 1 commit into from
Jan 6, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 4, 2018 •
edited by pr-preview bot
Loading

Fixes #555.

Preview | Diff

@annevk
Copy link
Member Author

annevk commented Jan 4, 2018

This requires whatwg/infra#187 to be merged first.

@annevk annevk mentioned this pull request Jan 4, 2018
Closed
domenic
domenic approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although will need to wait a day for the spec database I guess).

@annevk
Copy link
Member Author

annevk commented Jan 4, 2018 •
edited
Loading

Yeah, I'll force push tomorrow and see if stuff gets linked then.

@annevk
Copy link
Member Author

annevk commented Jan 5, 2018

This will have to wait until a day after whatwg/infra#184 lands and has successfully been deployed.

@annevk annevk merged commit 53511b8 into master Jan 6, 2018
@annevk annevk deleted the annevk/concat branch January 6, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic