Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: add commit and branch snapshots #83

Merged
merged 4 commits into from
Feb 17, 2017
Merged

Meta: add commit and branch snapshots #83

merged 4 commits into from
Feb 17, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 14, 2017

This moves the deploy process to be in line with most other WHATWG specifications; see whatwg/meta#2. It also adds the missing dfn.js file to get popups when clicking on elements and makes other small tweaks.

I know @robertkowalski did a lot of work to move the deploy process into the makefile, but we're pretty much using this similar deploy.sh script for all other repos, so it's probably best to be uniform.

Let's see if Travis likes this as a PR...

This moves the deploy process to be in line with most other WHATWG specifications; see whatwg/meta#2. It also adds the missing dfn.js file to get popups when clicking on <dfn> elements and makes other small tweaks.
@annevk
Copy link
Member

annevk commented Feb 13, 2017

I guess at this point we should make this use the central deploy script?

@domenic
Copy link
Member Author

domenic commented Feb 13, 2017

We'd need to add emu-algify to the central deploy script first, for both this and streams... I guess I should work on that.

@robertkowalski
Copy link
Member

wow thats super cool!

(and no worries, i don't cling to to the makefile)

I guess at this point we should make this use the central deploy script?

I assume this isn't blocking the merge?

@robertkowalski
Copy link
Member

robertkowalski commented Feb 14, 2017

LGTM / +1

@robertkowalski robertkowalski self-requested a review February 14, 2017 22:58
@domenic domenic merged commit 36c3ee5 into master Feb 17, 2017
@domenic domenic deleted the snapshots branch February 17, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants