Meta: use the common deploy.sh (with POST_BUILD_STEP) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few issues:
|
It's because of the images/ subdirectory. Turns out that
The POST_BUILD_STEP var needs to be moved to Makefile, but I've made it so, pushing changes momentarily. |
foolip
added a commit
to whatwg/whatwg.org
that referenced
this pull request
Sep 4, 2017
... with the magic of rsync. Will be used for whatwg/console#118.
|
This PR now depends on whatwg/whatwg.org#88, branch build will probably fail or be broken. |
domenic
approved these changes
Sep 4, 2017
foolip
added a commit
to whatwg/whatwg.org
that referenced
this pull request
Sep 4, 2017
... with the magic of rsync. Will be used for whatwg/console#118.
|
Restarting both builds to see if the world is broken. |
|
It worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of whatwg/meta#11.