Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: clean up examples #64

Merged
merged 1 commit into from
May 30, 2024
Merged

Editorial: clean up examples #64

merged 1 commit into from
May 30, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented May 30, 2024 •
edited by pr-preview bot
Loading

  • Wrap the <pre>s in <div>s to work better with the WHATWG stylesheet.
  • Add IDs to suppress Bikeshed warnings
  • Clean up the code a bit for the deflate-compress example, notably by using async iteration.

Preview | Diff

@domenic
Editorial: clean up examples
ed2b0bc 
* Wrap the <pre>s in <div>s to work better with the WHATWG stylesheet.
* Add IDs to suppress Bikeshed warnings
* Clean up the code a bit for the deflate-compress example, notably by using async iteration.
ricea
ricea approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@annevk annevk merged commit f9bbac4 into main May 30, 2024
1 check passed
@annevk annevk deleted the examples branch May 30, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricea ricea ricea approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenic @annevk @ricea